Updated ret opcode test.

[Alon-Ti]

This change is 

[Alon-Ti]

• Updated ret opcode test. #52 👈 (View in Graphite)
• Parallelized add_mul trace gen. #51
• refactor: use stwo_air_utils for par air generation #50
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[giladchase]

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion

---

crates/prover/src/components/ret_opcode/mod.rs line 70 at r1 (raw file):

            };
            256
        ]);

Why cant we add another state here to verify the ret switched to the correct state, like in the addmul test? something like:

chain!(
            VmState {
                pc: 0,
                ap: 3,
                fp: 3,
            };
            128,
              vec![
                    VmState {
                        pc: 5678, // probably need smaller numbers here and in fp to make it easier.
                        ap: 7,
                        fp: 1234,
                    };
                    128
                ]
).collect_vec()

I tried adding this, and it passed, but also putting incorrect values in PC/fp worked 😅

Code quote:

        let claim_generator = ClaimGenerator::new(vec![
            VmState {
                pc: 0,
                ap: 3,
                fp: 3,
            };
            256
        ]);

[Alon-Ti]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @giladchase)

---

crates/prover/src/components/ret_opcode/mod.rs line 70 at r1 (raw file):

Previously, giladchase wrote…

Why cant we add another state here to verify the ret switched to the correct state, like in the addmul test? something like:

chain!(
            VmState {
                pc: 0,
                ap: 3,
                fp: 3,
            };
            128,
              vec![
                    VmState {
                        pc: 5678, // probably need smaller numbers here and in fp to make it easier.
                        ap: 7,
                        fp: 1234,
                    };
                    128
                ]
).collect_vec()

I tried adding this, and it passed, but also putting incorrect values in PC/fp worked 😅

The execution is just a set of states, you can't assume that two consecutive ones feed into each other...

[graphite-app]

Merge activity

• Mar 2, 4:50 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

[giladchase]

Reviewed 2 of 3 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)