fix: Bug with skin tone emojis when using prevGraphemeClusterBreak package #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Apr 7, 2024
kgryte
requested changes
Apr 7, 2024
There was a problem hiding this comment.
(1) It looks like you are using language features which are beyond ES5. (2) You are performing repeated and unnecessary application of the regular expression. (3) Your PR is not accompanied by any additional tests.
As such, this PR cannot move forward until the above is addressed.
kgryte
added
the
Needs Changes
kgryte
reviewed
Apr 14, 2024
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 14, 2024
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Apr 14, 2024
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
Planeshifter
added
the
Potential Duplicate
kgryte
added
the
autoclose: Stale
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1092
Description
There's an issue with prevGraphemeClusterBreak package, if I compare the results with nextGraphemeClusterBreak for a single skin tone emoji it doesn't return the same values,
Related Issues
This pull request:
prevGraphemeClusterBreakpackage #1092Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers