Skip to content

refactor: update offset handling and function documentation for blas/ext/base/dsnannsumors #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2024
Merged

refactor: update offset handling and function documentation for blas/ext/base/dsnannsumors #3129

merged 4 commits into from
Nov 18, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • fix the ndarray function description and the parameter description
  • update logic to compute offsetOut
  • add the missing float suffx.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 17, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsnannsumors $\color{green}411/411$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}411/411$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Nov 17, 2024
View reviewed changes
kgryte
kgryte reviewed Nov 17, 2024
View reviewed changes
kgryte
kgryte reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is looking good. Just a question regarding whether a variable is actually needed.

@Planeshifter
Copy link
Member

/stdlib merge

@kgryte kgryte added the Needs Discussion Needs further discussion. label Nov 18, 2024
kgryte
kgryte approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Discussion Needs further discussion. label Nov 18, 2024
@kgryte kgryte merged commit 22b7505 into stdlib-js:develop Nov 18, 2024
11 checks passed
@headlessNode headlessNode deleted the dsnannsumors-refactor branch November 18, 2024 07:39
@headlessNode headlessNode mentioned this pull request Nov 18, 2024
Merged
1 task
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Nov 18, 2024
@headlessNode @stdlib-bot @saurabhraghuvanshii
refactor: update offset handling and function documentation for `bl…
baa4dcb 
…as/ext/base/dsnannsumors`

PR-URL: stdlib-js#3129
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Planeshifter referenced this pull request Dec 1, 2024
@GittyHarsha @Planeshifter
refactor: update blas/ext/base/dsnannsumors
7cc8bb9 
PR-URL: #2804
Closes:  #1491 
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@headlessNode @stdlib-bot @Planeshifter @kgryte