refactor: update offset handling and function documentation for blas/ext/base/dsnannsumors
#3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Nov 17, 2024
lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/src/addon.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 17, 2024
lib/node_modules/@stdlib/blas/ext/base/dsnannsumors/src/addon.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Nov 17, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
This PR is looking good. Just a question regarding whether a variable is actually needed.
Member
|
/stdlib merge |
1 task
saurabhraghuvanshii
pushed a commit
to saurabhraghuvanshii/stdlib-gs
that referenced
this pull request
Nov 18, 2024
…as/ext/base/dsnannsumors` PR-URL: stdlib-js#3129 Reviewed-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
Planeshifter
referenced
this pull request
Dec 1, 2024
PR-URL: #2804 Closes: #1491 Ref: #1152 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
ndarrayfunction description and the parameter descriptionoffsetOutfloatsuffx.Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers