Skip to content

bench: refactor random number generation in stats/base/dists/hypergeometric #4955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

bench: refactor random number generation in stats/base/dists/hypergeometric #4955

merged 1 commit into from
Jan 30, 2025

Conversation

@anandkaranubc
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for stats/base/dists/hypergeometric.
  • Replaces randu() with uniform() for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
bench: move random number generation outside the benchmarking loops
dccad5f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@anandkaranubc
Copy link
Contributor Author

A lot of minor changes have been made in this PR regarding the range of variables in benchmarks, using discrete-uniform to mitigate any chances of benchmarks producing NaN.

Planeshifter
Planeshifter approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anandkaranubc!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 30, 2025
@Planeshifter Planeshifter merged commit b9bddfe into stdlib-js:develop Jan 30, 2025
22 of 27 checks passed
This was referenced Jan 31, 2025
Open
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Open
Open
Closed
Open
Open
Closed
Closed
Closed
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@anandkaranubc @Vinit-Pandit
bench: refactor random number generation in `stats/base/dists/hyperge…
0341003 
…ometric`

PR-URL: stdlib-js#4955

Reviewed-by: Philipp Burckhardt <[email protected]>
@hrshya hrshya mentioned this pull request Feb 10, 2025
Merged
1 task
@G4URAV001 G4URAV001 mentioned this pull request Feb 10, 2025
Merged
Planeshifter added a commit that referenced this pull request Feb 12, 2025
@G4URAV001 @Planeshifter @stdlib-bot
bench: refactor random number generation in benchmarks for `stats/bas…
273d9f1 
…e/dists/uniform`

PR-URL: #5176
Closes: #4991
Ref: #4837
Ref: #4955

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
This was referenced Feb 13, 2025
Closed
Closed
Planeshifter pushed a commit that referenced this pull request Feb 17, 2025
@hrshya @anandkaranubc @stdlib-bot
bench: refactor random number generation in `stats/base/dists/student…
2f54879 
…ized-range`

PR-URL: #5175
Closes: #4987
Ref: #4955
Ref: #4837

Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by:  Karan Anand <[email protected]>
Signed-off-by: Harsh <[email protected]>
This was referenced Feb 20, 2025
Merged
Open
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@anandkaranubc @ShabiShett07
bench: refactor random number generation in `stats/base/dists/hyperge…
6fec5e9 
…ometric`

PR-URL: stdlib-js#4955

Reviewed-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@G4URAV001 @Planeshifter
@stdlib-bot @ShabiShett07
bench: refactor random number generation in benchmarks for `stats/bas…
45dd249 
…e/dists/uniform`

PR-URL: stdlib-js#5176
Closes: stdlib-js#4991
Ref: stdlib-js#4837
Ref: stdlib-js#4955

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@anandkaranubc anandkaranubc deleted the hypergeom-benchmarks branch May 10, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anandkaranubc @Planeshifter