Skip to content

feat: update random number generation function in triangular/logpdf #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 7, 2025
Merged

feat: update random number generation function in triangular/logpdf #5266

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b20e724
feat: add C implementation for triangular logpdf
0PrashantYadav0 Jan 9, 2025
a1280c4
chore: made changes as per code review
0PrashantYadav0 Jan 10, 2025
6e71faa
chore: apply suggestions from code review
Planeshifter Jan 19, 2025
ebf4636
chore: merge develop
0PrashantYadav0 Feb 17, 2025
8a85750
fix: changes in benchmarks
0PrashantYadav0 Feb 17, 2025
5223b20
chore: updated random generation function
0PrashantYadav0 Feb 17, 2025
57509b0
chore: update according to code review
0PrashantYadav0 Mar 1, 2025
ca56f54
fix: improve random number generation in triangular logpdf benchmark …
0PrashantYadav0 Mar 5, 2025
f2c1714
chore: changes in benchmark
0PrashantYadav0 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ y = mylogpdf( 12.0 );
<!-- eslint no-undef: "error" -->

```javascript
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var logpdf = require( '@stdlib/stats/base/dists/triangular/logpdf' );

var a;
Expand All @@ -145,10 +145,10 @@ var y;
var i;

for ( i = 0; i < 25; i++ ) {
x = randu() * 30.0;
a = randu() * 10.0;
b = a + (randu() * 40.0);
c = a + ((b-a) * randu());
x = uniform( 0.0, 30.0 );
a = uniform( 0.0, 10.0 );
b = uniform( a, a + 40.0 );
c = uniform( a, b );
y = logpdf( x, a, b, c );
console.log( 'x: %d, a: %d, b: %d, c: %d, ln(f(x;a,b,c)): %d', x.toFixed( 4 ), a.toFixed( 4 ), b.toFixed( 4 ), c.toFixed( 4 ), y.toFixed( 4 ) );
}
Expand Down
19 changes: 11 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var Float64Array = require( '@stdlib/array/float64' );
var EPS = require( '@stdlib/constants/float64/eps' );
Expand All @@ -45,12 +45,11 @@ bench( pkg, function benchmark( b ) {
min = new Float64Array( len );
max = new Float64Array( len );
mode = new Float64Array( len );

for ( i = 0; i < len; i++ ) {
x[ i ] = randu() * 30.0;
min[ i ] = randu() * 10.0;
max[ i ] = min[ i ] + ( randu() * 40.0 ) + EPS;
mode[ i ] = min[ i ] + ( ( max[ i ] - min[ i ] ) * randu() );
x[ i ] = uniform( 0.0, 30.0 );
min[ i ] = uniform( 0.0, 10.0 );
max[ i ] = uniform( min[ i ] + EPS, 40.0 + EPS + min[ i ] );
mode[ i ] = uniform( min[ i ], max[ i ] );
}

b.tic();
Expand All @@ -73,6 +72,7 @@ bench( pkg+':factory', function benchmark( b ) {
var mode;
var min;
var max;
var len;
var x;
var y;
var i;
Expand All @@ -81,11 +81,14 @@ bench( pkg+':factory', function benchmark( b ) {
max = 1.5;
mode = 0.5;
mylogpdf = logpdf.factory( min, max, mode );
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -2.0, 2.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 2.0;
y = mylogpdf( x );
y = mylogpdf( x[ x%x.length ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
11 changes: 5 additions & 6 deletions lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var EPS = require( '@stdlib/constants/float64/eps' );
Expand Down Expand Up @@ -54,12 +54,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
min = new Float64Array( len );
max = new Float64Array( len );
mode = new Float64Array( len );

for ( i = 0; i < len; i++ ) {
x[ i ] = randu() * 30.0;
min[ i ] = randu() * 10.0;
max[ i ] = min[ i ] + ( randu() * 40.0 ) + EPS;
mode[ i ] = min[ i ] + ( ( max[ i ] - min[ i ] ) * randu() );
x[ i ] = uniform( 0.0, 30.0 );
min[ i ] = uniform( 0.0, 10.0 );
max[ i ] = uniform( min[ i ] + EPS, 40.0 + EPS + min[ i ] );
mode[ i ] = uniform( max[ i ], max[ i ] );
}

b.tic();
Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/examples/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

'use strict';

var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var logpdf = require( './../lib' );

var a;
Expand All @@ -29,10 +29,10 @@ var y;
var i;

for ( i = 0; i < 25; i++ ) {
x = randu() * 30.0;
a = randu() * 10.0;
b = a + (randu() * 40.0);
c = a + ((b-a) * randu());
x = uniform( 0.0, 30.0 );
a = uniform( 0.0, 10.0 );
b = uniform( a, a + 40.0 );
c = uniform( a, b );
y = logpdf( x, a, b, c );
console.log( 'x: %d, a: %d, b: %d, c: %d, ln(f(x;a,b,c)): %d', x.toFixed( 4 ), a.toFixed( 4 ), b.toFixed( 4 ), c.toFixed( 4 ), y.toFixed( 4 ) );
}