feat: add `array/base/map` #5346

headlessNode · 2025-02-21T00:14:35Z

Description

What is the purpose of this pull request?

This pull request:

adds array/base/map function including tests, benchmarks and documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add array/base/map metr-issue-tracker#21

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-02-21T00:16:10Z

Coverage Report

Package	Statements	Branches	Functions	Lines
array/base/map	$\color{green}318/318$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}318/318$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

headlessNode · 2025-02-21T00:49:44Z

Will open for final review, after a self-review some time today.

lib/node_modules/@stdlib/array/base/map/README.md

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/array/base/map/README.md

lib/node_modules/@stdlib/array/base/map/docs/repl.txt

lib/node_modules/@stdlib/array/base/map/docs/types/index.d.ts

lib/node_modules/@stdlib/array/base/map/lib/assign.js

lib/node_modules/@stdlib/array/base/map/lib/main.js

lib/node_modules/@stdlib/array/base/map/test/test.main.js

lib/node_modules/@stdlib/array/base/map/lib/main.js

kgryte

Left an initial round of comments. This package needs a fair amount of refactoring before we can merge.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

lib/node_modules/@stdlib/array/base/map/README.md

lib/node_modules/@stdlib/array/base/map/benchmark/benchmark.assign.js

lib/node_modules/@stdlib/array/base/map/docs/repl.txt

lib/node_modules/@stdlib/array/base/map/lib/assign.js

lib/node_modules/@stdlib/array/base/map/test/test.assign.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/array/base/map/lib/assign.js

Signed-off-by: Muhammad Haris <[email protected]>

… into array-base-map

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

headlessNode · 2025-02-22T22:23:11Z

This was THE PR of mine with most amount of suggestions, ever. 😅

lib/node_modules/@stdlib/array/base/map/lib/assign.js

lib/node_modules/@stdlib/array/base/map/test/test.assign.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

…/headlessNode/5346

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

kgryte

LGTM after clean-up.

headlessNode mentioned this pull request Feb 21, 2025

[RFC]: add array/base/map stdlib-js/metr-issue-tracker#21

Closed

headlessNode added the Feature Issue or pull request for adding a new feature. label Feb 21, 2025

headlessNode commented Feb 21, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/README.md Outdated Show resolved Hide resolved

docs: apply suggestions from code review

2ea05a5

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode marked this pull request as ready for review February 21, 2025 11:02

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 21, 2025

kgryte reviewed Feb 21, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/README.md Outdated Show resolved Hide resolved

kgryte reviewed Feb 21, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/repl.txt Show resolved Hide resolved

kgryte reviewed Feb 21, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/test/test.main.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/test/test.main.js Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/main.js Outdated Show resolved Hide resolved

kgryte requested changes Feb 22, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 22, 2025

headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Feb 22, 2025

headlessNode requested a review from kgryte February 22, 2025 08:41

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 22, 2025

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/README.md Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/benchmark/benchmark.assign.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

headlessNode commented Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

headlessNode commented Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/test/test.assign.js Show resolved Hide resolved

docs: apply suggestions from code review

968cc8b

Signed-off-by: Muhammad Haris <[email protected]>

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 22, 2025

headlessNode commented Feb 22, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

headlessNode added 3 commits February 23, 2025 02:49

refactor: apply suggestions from code review

b208157

Signed-off-by: Muhammad Haris <[email protected]>

Merge branch 'array-base-map' of https://github.com/headlessNode/stdlib…

f24a5d3

… into array-base-map

headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Feb 22, 2025

headlessNode requested review from kgryte February 22, 2025 22:19

kgryte reviewed Feb 23, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/lib/assign.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 23, 2025

View reviewed changes

lib/node_modules/@stdlib/array/base/map/test/test.assign.js Outdated Show resolved Hide resolved

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 23, 2025

headlessNode requested review from kgryte February 23, 2025 05:34

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 23, 2025

headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Feb 23, 2025

kgryte added 2 commits March 17, 2025 17:41

Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…

fdc476c

…/headlessNode/5346

kgryte approved these changes Mar 18, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Mar 18, 2025

kgryte merged commit 9b2b107 into stdlib-js:develop Mar 18, 2025
13 checks passed

Uh oh!

feat: add array/base/map #5346

feat: add array/base/map #5346

Uh oh!

Conversation

headlessNode commented Feb 21, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

headlessNode commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Feb 22, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `array/base/map` #5346

feat: add `array/base/map` #5346

stdlib-bot commented Feb 21, 2025 •

edited

Loading