fix: resolve ESLint errors by replacing new Array()

[AlyAbdelmoneim]

Resolves #6032.

Description

What is the purpose of this pull request?

This pull request:

• Addresses issue Fix JavaScript lint errors #6032 by implementing the necessary changes to improve the functionality of the feature, by using push instead of pre-allocating the memory.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves Fix JavaScript lint errors #6032.

Questions

Any questions for reviewers of this pull request?

I encountered an issue when running the linting process due to an error related to EditorConfig. The error message indicated that the "path" argument was invalid, specifically that it was undefined. I would appreciate any guidance on how to resolve this or improve the configuration for linting.

Other

During the commit process, an error occurred in the linting task related to EditorConfig. The error traceback indicated that the "path" argument was expected to be a string but was undefined, causing the linting task to fail. I manually resolved this issue and ran the commit successfully after ensuring the configuration was correct. Any feedback on improving the linting process would be helpful.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[Planeshifter]

Notice the lint error message:

Using the new Array() constructor is not allowed; use an array literal with push instead

We want to use .push instead of pre-allocating space for all the elements.

[AlyAbdelmoneim]

Also can you explain for me why using .push is better than pre-allocating ? I thought pre-allocating is better performance-wise.
Thank youu

[kgryte]

LGTM

[kgryte]

@AlyAbdelmoneim Re: perf. Not with Array. The reason is that new Array( N ) can put the returned value in dictionary mode which can significantly slow performance. Instead, it is advisable to use .push in order to ensure "fast" mode and contiguous elements.