Skip to content

Conversation

Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Mar 15, 2025

Progresses #649.
Resolves #6076 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/ln-sqrt-two-pi

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 15, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/ln-sqrt-two-pi $\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 15, 2025 15:04
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 15, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft March 16, 2025 09:43
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review March 16, 2025 09:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@kgryte kgryte removed the Potential Duplicate There might be another pull request resolving the same issue. label Mar 19, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the README comments, this looks fine. Applies to your other PRs, as well.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 19, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 19, 2025
@kgryte kgryte merged commit 0e0ee1f into stdlib-js:develop Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/ln-sqrt-two-pi

4 participants