Skip to content

Conversation

usbalbin
Copy link
Member

No description provided.

@astapleton
Copy link
Member

Hey @usbalbin. I think we've got some duplicated work here. I've got some unpublished branches that update the stm32-rs dependency and bring in changes to support the rest of the H5 family (notably adding all the peripheral clock enable definitions and add the rest of the GPIOs). Those changes do depend on an updated version of the stm32h5 crate. However, the upstream stm32-rs crate is changing quite rapidly at the moment, so targeting the nightly might be quite disruptive to PRs.

@burrbull you previously published a stm32h5-staging crate, but I see you've since un-published/yanked/deleted it. I was wondering whether you have an idea when new stm32-rs pac crates will be published, or whether you could re-publish the stm32h5-staging crate from master?

@astapleton
Copy link
Member

One of the branches I was working on, for reference: https://github.com/stm32-rs/stm32h5xx-hal/tree/as/peripheral-rec-all-h5

@burrbull
Copy link
Member

burrbull commented Jan 6, 2025

i did not yank anything. it is still on crates.io

@burrbull
Copy link
Member

burrbull commented Jan 6, 2025

i can release a new staging version as most of update/refactoring work is done

@usbalbin
Copy link
Member Author

usbalbin commented Jan 6, 2025

One of the branches I was working on, for reference: https://github.com/stm32-rs/stm32h5xx-hal/tree/as/peripheral-rec-all-h5

I am happy to try rebasing over that if it would be helpful.

@usbalbin
Copy link
Member Author

usbalbin commented Jan 6, 2025

i can release a new staging version as most of update/refactoring work is done

In that case, I can update this(or a rebased version of this) to depend on that :)

@burrbull
Copy link
Member

burrbull commented Jan 6, 2025

https://crates.io/crates/stm32h5-staging/0.17.0

@astapleton
Copy link
Member

i did not yank anything. it is still on crates.io

Huh. I must have used the wrong name earlier. Thanks for updating it!

@astapleton
Copy link
Member

i can release a new staging version as most of update/refactoring work is done

In that case, I can update this(or a rebased version of this) to depend on that :)

Yeah, how about you update this to depend on the staging crate and then I can rebase the RCC reset/enable changes on top?

@usbalbin
Copy link
Member Author

usbalbin commented Jan 6, 2025

i can release a new staging version as most of update/refactoring work is done

In that case, I can update this(or a rebased version of this) to depend on that :)

Yeah, how about you update this to depend on the staging crate and then I can rebase the RCC reset/enable changes on top?

Done

@usbalbin usbalbin marked this pull request as ready for review January 6, 2025 21:25
Copy link
Member

@astapleton astapleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@astapleton astapleton merged commit 86ec4c5 into stm32-rs:master Jan 6, 2025
15 checks passed
@astapleton astapleton mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants