feat(pg_upgrade): use self-hosted nix installer if available; move files out of /tmp #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrose
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Seems like a reasonable approach to me.
The one caveat is that there can be security issues with specific versions of nix, which tend to be fixed and then distributed with the installer by DS.
So, we should definitely have a process to keep out self-hosted installer up to date on a weekly basis or so, outside of the operation it is being used for.
pcnc
changed the title
|
Moving into draft as it still needs some testing |
pcnc
force-pushed
the
pcnc/pinned-nix-installer
branch
from
53970fb to
ed63ed7
Compare
thebengeu
approved these changes
Sep 13, 2024
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.