Skip to content

chore(actions): harden release action and clean up ci #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore(actions): harden release action and clean up ci #966

merged 1 commit into from
Aug 22, 2024

Conversation

dominikg
Copy link
Member

  • --prefer-offline isn't needed
  • pinning changesets/action prevents malicious updates creeping in
  • remove .npmrc after use to avoid it leaking token

pngwn
pngwn approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice catch about the npmrc.

@dominikg dominikg merged commit 54fa669 into main Aug 22, 2024
6 checks passed
@dominikg dominikg deleted the chore/harden-actions branch August 22, 2024 09:16
@dominikg dominikg mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pngwn pngwn pngwn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikg @pngwn