Remove unecessary check on Webpack version 4 #1381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #1382 |
Kocal
added a commit
that referenced
this pull request
Aug 3, 2025
…previously embedded in #921 (Kocal) This PR was merged into the main branch. Discussion ---------- Re-add `webpack-manifest-plugin` dependency, which was previously embedded in #921 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update CHANGELOG.md file --> | Deprecations? | no <!-- please update CHANGELOG.md file --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility. --> While working on #1381, I noticed that `lib/webpack-manifest-plugin/` was https://github.com/shellscape/webpack-manifest-plugin embedded with fix shellscape/webpack-manifest-plugin#249 The package was embedded because it was possible for the upstream PR to never be merged, but it has been merged and released. We should not have any BCs from https://github.com/shellscape/webpack-manifest-plugin/releases Commits ------- d5d6b7b Re-add webpack-manifest-plugin as a dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not support Webpack 4 since a moment now, we can remove this check and import to
webpack