Skip to content

Re-add webpack-manifest-plugin dependency, which was previously embedded in #921 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 3, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

While working on #1381, I noticed that lib/webpack-manifest-plugin/ was https://github.com/shellscape/webpack-manifest-plugin embedded with fix shellscape/webpack-manifest-plugin#249

The package was embedded because it was possible for the upstream PR to never be merged, but it has been merged and released.

We should not have any BCs from https://github.com/shellscape/webpack-manifest-plugin/releases

@carsonbot carsonbot added Feature New Feature Status: Needs Review Needs to be reviewed labels Aug 3, 2025
@Kocal Kocal force-pushed the re-add-webpack-manifest-plugin-dependency branch from b765b91 to 77de962 Compare August 3, 2025 09:33
@Kocal Kocal force-pushed the re-add-webpack-manifest-plugin-dependency branch from 77de962 to d5d6b7b Compare August 3, 2025 09:40
@Kocal Kocal merged commit e5112e5 into symfony:main Aug 3, 2025
34 checks passed
@Kocal Kocal deleted the re-add-webpack-manifest-plugin-dependency branch August 3, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants