Enhance code reusability for the compiler backends #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Nov 23, 2024
src/riscv-codegen.c
Outdated
| * 2. load and store operations. | ||
| */ | ||
| rv_reg soft_div_rd = __t0, divisor_mask = __t1; | ||
| rv_reg helper_reg, divisor_mask = __t1; |
Collaborator
There was a problem hiding this comment.
Instead of naming it helper_reg, how about interm, which is the abbreviated form of "intermediate"? i.e., place an intermediate register for the division/modulo and load-store instructions.
vacantron
approved these changes
Nov 23, 2024
Collaborator
vacantron
left a comment
vacantron
left a comment
There was a problem hiding this comment.
Except the naming mentioned above, the changes look good to me.
Collaborator
Author
|
Because of pushing a redundant commit, I will squash the commits later. |
After observing ARM and RISC-V backends, the instruction sequences of load and global load operations are very similar, and both of them just use a different register for two instructions. A similar situation occurs for store and global store operations. Therefore, this commit improves the compiler backends to reuse the same code more efficiently.
DrXiao
force-pushed
the
fix-load-store
branch
from
902e0fb to
0684f41
Compare
Collaborator
|
Thank @DrXiao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After observing ARM and RISC-V backends, I noticed that the instruction sequences of load and global load operations are very similar:
/* ARM backend */ if (ph2_ir->src0 > 4095) { emit(__movw(__AL, __r8, ph2_ir->src0)); emit(__movt(__AL, __r8, ph2_ir->src0)); - emit(__add_r(__AL, __r8, __sp, __r8)); /* OP_load */ + emit(__add_r(__AL, __r8, __r12, __r8)); /* OP_global_load */ emit(__lw(__AL, rd, __r8, 0)); } else - emit(__lw(__AL, rd, __sp, ph2_ir->src0)); /* OP_load */ + emit(__lw(__AL, rd, __r12, ph2_ir->src0)); /* OP_global_load */A similar case occurs for store and global store operations.
Thus, this pull request improves code reusability for the compiler backends.