Add test cases and arbitrary test case setup function #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
commented
Aug 22, 2025
carlydf
commented
Aug 22, 2025
robholland
reviewed
Aug 22, 2025
jlegrone
reviewed
Aug 22, 2025
jlegrone
reviewed
Aug 22, 2025
jlegrone
reviewed
Aug 22, 2025
jlegrone
reviewed
Aug 22, 2025
jlegrone
approved these changes
Aug 22, 2025
Collaborator
jlegrone
left a comment
jlegrone
left a comment
There was a problem hiding this comment.
lgtm, just a few small style/documentation suggestions!
Use else if to make the conditional logic clearer in the inactive version scaling code. Addresses: temporalio#127 (comment)
jlegrone
added a commit
that referenced
this pull request
Aug 25, 2025
Change TaskQueueEnvKey to taskQueueEnvKey since it's not used outside the package. Addresses: #127 (comment)
jlegrone
added a commit
that referenced
this pull request
Aug 25, 2025
Change TaskQueueEnvKey to taskQueueEnvKey since it's not used outside the package. Addresses: #127 (comment)
Change TaskQueueEnvKey to taskQueueEnvKey since it's not used outside the package. Addresses: temporalio#127 (comment)
- Move field descriptions from README to proper godoc comments on TestCase struct - Create testable examples in example_test.go with compile-time checks - Update README to reference godoc and examples instead of duplicating struct definition Addresses: temporalio#127 (comment)
Address PR review comments
jlegrone
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add arbitrary test case setup function to set up non-standard test cases with environments that are not represented in
TemporalWorkerDeploymentStatus.Add test cases:
Why?
We want coverage of these scenarios want to build out our ability to add more scenarios
Checklist
Closes TEST: Controller doesn't scale down Inactive workers for failed test workflows -> scale down inactive versions that are not the target #33
How was this tested:
This PR adds tests
The manual mode test and the scaling down inactive versions test needed Controller code changes to pass, so I saw them fail, thereby ensuring that the test actually tests what I say it does.
Any docs updates needed?
TODO: Possibly mention this in definition of Inactive version status, actually. Or in description of Worker Controller Scaling Behavior