Skip to content

Conversation

@arya-girish-k
Copy link

Description

Add UI regex valiadation in ibm_catalog.json.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR enables input validation in the UI for several string variables by leveraging the value_constraints array defined in the catalog. These constraints will be used by the UI to validate user input at runtime. The changed variables include:
prefix,existing_secrets_manager_crn,internet_services_crn,acme_letsencrypt_private_key_secrets_manager_secret_crn.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

arya-girish-k commented Oct 28, 2025

Tested the variables against different patterns, including null values, incorrect inputs, and correct inputs. Corresponding screenshots are attached below.

  • existing_secrets_manager_crn
Pasted Graphic 104 Pasted Graphic 105 existing_secrets_manager_crn ®
  • acme_letsencrypt_private_key_secrets_manager_secret_crn
acme_letsencrypt_private_key_secrets_manager_secret_crn ® acme_letsencrypt_private_key_secrets_manager_secret_crn acme_letsencrypt_private_key_secrets_manager_secret_crn ©
  • internet _services_crn
Pasted Graphic 110 The value provided for 'internet _services_crn' is not valid Pasted Graphic 112

@arya-girish-k arya-girish-k marked this pull request as ready for review October 28, 2025 09:08
mukulpalit-ibm
mukulpalit-ibm previously approved these changes Oct 29, 2025
Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Please add the validation to the terraform code too

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

arya-girish-k commented Oct 31, 2025

Added validation and tested,PFA for the incorrect inputs.

  • internet_services_crn
var internet_services_crn is crn
  • existing_secrets_manager_crn
Pasted Graphic 14
  • acme_letsencrypt_private_key_secrets_manager_secret_crn
Pasted Graphic 15

@arya-girish-k
Copy link
Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants