Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating icon imports and usage across several components in the dashboard. It replaces icons from react-icons with those from lucide-react, improving consistency in iconography.

Detailed summary

  • Replaced FiX with XIcon in SmartWalletsBillingAlert.
  • Changed CircleAlert to CircleAlertIcon in AirdropTable.
  • Updated FiUpload to UploadIcon in IconUpload.
  • Combined FiSearch and WandIcon into SearchIcon and WandIcon in HackathonEarnFooter.
  • Replaced BsLightningCharge with ZapIcon in Community.
  • Updated various icons in AirdropTable to use CircleAlertIcon, Chevron*Icons, and other lucide icons.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 6ff85d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:17pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 3, 2024 4:17pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 3, 2024 4:17pm
wallet-ui ⬜️ Skipped (Inspect) Oct 3, 2024 4:17pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 22:08 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 22:08 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024
Copy link
Contributor Author

kien-ngo commented Oct 2, 2024

@kien-ngo kien-ngo changed the title [Dashboard] Remove recat-icons (3) [Dashboard] Remove react-icons (3) Oct 2, 2024
@kien-ngo kien-ngo marked this pull request as ready for review October 2, 2024 22:08
@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (37d62e2) to head (6ff85d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4898   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57221    57221           
  Branches     3924     3924           
=======================================
  Hits        27246    27246           
  Misses      29286    29286           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 37d62e2
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 612 ms (+42.63% 🔺) 1.5 s
thirdweb (cjs) 101.63 KB (0%) 2.1 s (0%) 1.6 s (+3.38% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 70 ms (+37.95% 🔺) 167 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 40 ms (+94.61% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 244 ms (+150.54% 🔺) 589 ms

@kien-ngo kien-ngo force-pushed the kien/remove-react-icons-2 branch from b937029 to 5b4e974 Compare October 2, 2024 22:12
@kien-ngo kien-ngo force-pushed the kien/remove-react-icons-3 branch from 25f91c3 to fd0e97a Compare October 2, 2024 22:12
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 22:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 22:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 22:12 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-react-icons-2 branch from 5b4e974 to 4323035 Compare October 3, 2024 02:20
@kien-ngo kien-ngo force-pushed the kien/remove-react-icons-3 branch from fd0e97a to 594ca68 Compare October 3, 2024 02:20
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 02:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 02:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 02:20 Inactive
@MananTank MananTank force-pushed the kien/remove-react-icons-3 branch from 99f1e4a to 309726a Compare October 3, 2024 12:41
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 12:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 12:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 12:41 Inactive
@MananTank MananTank changed the base branch from graphite-base/4898 to main October 3, 2024 12:41
@MananTank MananTank force-pushed the kien/remove-react-icons-3 branch from 309726a to 7cf8426 Compare October 3, 2024 12:41
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 12:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 12:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 12:41 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-react-icons-3 branch from 7cf8426 to 9ec8c9f Compare October 3, 2024 14:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 14:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 14:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 14:19 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating icon imports from `react-icons` to `lucide-react` across multiple components, enhancing consistency and potentially improving performance.

### Detailed summary
- Replaced `FiX` with `XIcon` in `SmartWalletsBillingAlert`.
- Replaced `CircleAlert` with `CircleAlertIcon` in `AirdropTable`.
- Replaced `FiUpload` with `UploadIcon` in `IconUpload`.
- Updated `HackathonEarnFooter` to use `SearchIcon`.
- Replaced `BsLightningCharge` with `ZapIcon` in `Community`.
- Replaced `IoAlertCircleOutline` with `CircleAlertIcon` in `AirdropTable`.
- Updated pagination icons in `AirdropTable` to use `Chevron` icons from `lucide-react`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/remove-react-icons-3 branch from 9ec8c9f to 6ff85d3 Compare October 3, 2024 16:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 16:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 16:08 Inactive
@graphite-app graphite-app bot merged commit 6ff85d3 into main Oct 3, 2024
27 checks passed
@graphite-app graphite-app bot deleted the kien/remove-react-icons-3 branch October 3, 2024 16:18
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 3, 2024 16:18 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 3, 2024 16:18 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 3, 2024 16:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants