[Dashboard] Remove react-icons (5) #4904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4904 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/remove-react-icons-4
branch
from
7a42cbb to
0dab465
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-5
branch
from
54406f5 to
fdd9a57
Compare
MananTank
force-pushed
the
kien/remove-react-icons-4
branch
from
0dab465 to
4c4d3b4
Compare
MananTank
force-pushed
the
kien/remove-react-icons-5
branch
from
fdd9a57 to
ee7542f
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-4
branch
from
4c4d3b4 to
c372498
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-5
branch
from
ee7542f to
d311838
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-5
branch
from
4686670 to
9db3761
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-5
branch
from
9db3761 to
ad1dd2a
Compare
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on replacing icon imports from `react-icons` with `lucide-react` icons across various components in the dashboard application, enhancing the visual consistency and potentially improving performance.
### Detailed summary
- Replaced `FiEye` with `EyeIcon` in `reveal-button.tsx`.
- Replaced `FiCopy` with `CopyIcon` in `LatestEvents.tsx`.
- Replaced `BsLightningCharge` with `ZapIcon` in `GeneralCta.tsx`.
- Replaced `FiCheck` with `CheckIcon` in `address-input.tsx`.
- Replaced `FaXTwitter` with `XIcon` and `SiOpensea` with `OpenseaIcon` in `OpCreditsGrantedModal.tsx`.
- Replaced `FiX` with `XIcon` and caret icons with `ChevronDownIcon`, `ChevronUpIcon` in `phase.tsx`.
- Replaced `FiPlay` with `PlayIcon` and `FaCircleInfo` with `InfoIcon` in `interactive-abi-function.tsx`.
- Replaced `FiInfo` with `InfoIcon` in `list-form.tsx`.
- Replaced navigation icons in `accounts-table.tsx` with `Chevron` icons from `lucide-react`.
- Added `OpenseaIcon` component in `OpenseaIcon.tsx`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
kien/remove-react-icons-5
branch
from
ad1dd2a to
a7e285a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing icons from
react-iconswithlucide-reacticons across various components for a more consistent icon set. Additionally, it makes minor adjustments to the code structure.Detailed summary
FiEyewithEyeIconinNFTRevealButton.FiCopywithCopyIconinLatestEvents.BsLightningChargewithZapIconinGeneralCta.FiCheckwithCheckIconinSolidityAddressInput.FaXTwitterwithXIconandSiOpenseawithOpenseaIconinOpCreditsGrantedModal.FiX,RxCaretDown, andRxCaretUpwithXIcon,ChevronDownIcon, andChevronUpIconinClaimConditionsPhase.FiPlaywithPlayIconandFaCircleInfowithInfoIconinInteractiveAbiFunction.FiInfowithInfoIconinCreateListingsForm.Mdicons withChevronicons inAccountsTable.OpenseaIconcomponent definition.