[Dashboard] Vote contract proposal drawer #4899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4899 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/remove-react-icons-3
branch
from
25f91c3 to
fd0e97a
Compare
kien-ngo
force-pushed
the
kien/proposal-drawer
branch
from
ab0af0d to
16301f8
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-3
branch
from
fd0e97a to
594ca68
Compare
kien-ngo
force-pushed
the
kien/proposal-drawer
branch
from
16301f8 to
71950c5
Compare
kien-ngo
force-pushed
the
kien/proposal-drawer
branch
from
4cdc2ab to
298ed24
Compare
MananTank
approved these changes
Oct 3, 2024
Contributor
Merge activity
|
MananTank
changed the base branch from
kien/remove-react-icons-3
to
graphite-base/4899
kien-ngo
force-pushed
the
kien/proposal-drawer
branch
from
298ed24 to
f8bbc57
Compare
kien-ngo
force-pushed
the
graphite-base/4899
branch
from
9ec8c9f to
47f5387
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the proposal creation UI components, replacing a `Drawer` with a `Sheet` for better user experience, and enhancing the proposal submission process with improved form handling and error management.
### Detailed summary
- Deleted `proposal-form.tsx`.
- Modified `metadata-header.tsx` className for better styling.
- Replaced `Flex` components with `div` for layout in `page.tsx`.
- Refactored `ProposalButton` to use `Sheet` instead of `Drawer`.
- Added form handling with `react-hook-form` in `ProposalButton`.
- Implemented error handling and user feedback with `toast` in the proposal submission process.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/proposal-drawer
branch
from
f8bbc57 to
4b80b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the proposal creation UI components in a decentralized application. It replaces the
Drawercomponent with aSheetcomponent for better styling and functionality, and improves the form handling for creating proposals.Detailed summary
proposal-form.tsx.metadata-header.tsxto adjust theclassNamefor theLink.page.tsxfromFlextodivfor better structure.ProposalButtoninproposal-button.tsx:DrawerwithSheet.react-hook-form.