Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the MobileMenu component in the apps/dashboard/src/components/product-pages/common/nav/MobileMenu.tsx file, transitioning from a Drawer to a Sheet component for better UI management and state handling.

Detailed summary

  • Removed display prop from MobileMenu in Topnav.tsx.
  • Changed MobileMenu from using useDisclosure to useState for open state management.
  • Replaced Drawer with Sheet for displaying the mobile menu.
  • Updated IconButton size in MobileMenu.
  • Modified onItemClick to close the menu using setOpen(false).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:45am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 2:45am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 2:45am
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 2:45am

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 7bfad6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 23:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 23:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 23:14 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 11, 2024
Copy link
Contributor Author

kien-ngo commented Oct 11, 2024

@kien-ngo kien-ngo marked this pull request as ready for review October 11, 2024 23:15
@kien-ngo kien-ngo self-assigned this Oct 11, 2024
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (6faf63f) to head (7bfad6e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4999   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files        1058     1058           
  Lines       54670    54670           
  Branches     3950     3950           
=======================================
  Hits        24757    24757           
  Misses      29222    29222           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6faf63f
packages 40.21% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 396 ms (-9.43% 🔽) 1.3 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 864 ms (+6.8% 🔺) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 44 ms (+34.11% 🔺) 141 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 18 ms (+96.39% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 107 ms (-20.11% 🔽) 454 ms

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a few adjustments to UI while we are making changes here

  1. Increase the icon size ( its currently 16x16 ) - lets change make it size-6

image.png

  1. Let's add a py-2 on all the links so its easier to click on them. ( lets also make sure the sheet has overflow auto )

image.png

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `MobileMenu` component in the `apps/dashboard/src/components/product-pages/common/nav/MobileMenu.tsx` file by replacing the `Drawer` component with a new `Sheet` component for improved UI handling.

### Detailed summary
- Removed `display` prop from `MobileMenu` in `Topnav.tsx`.
- Changed `MobileMenu` from using `useDisclosure` to `useState` for open state management.
- Replaced `Drawer` with `Sheet` for menu display.
- Updated `IconButton` size in `MobileMenu`.
- Adjusted `onItemClick` handlers to close the menu using `setOpen(false)`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the kien/mobile-menu-drawer branch from 9768993 to 7bfad6e Compare October 15, 2024 02:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 02:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 02:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 02:42 Inactive
@graphite-app graphite-app bot merged commit 7bfad6e into main Oct 15, 2024
30 checks passed
@graphite-app graphite-app bot deleted the kien/mobile-menu-drawer branch October 15, 2024 02:46
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 02:46 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 02:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants