-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Mobile menu drawer -> Sheet #4999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1058 1058
Lines 54670 54670
Branches 3950 3950
=======================================
Hits 24757 24757
Misses 29222 29222
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
1fb47d7 to
aeff529
Compare
aeff529 to
5174dae
Compare
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address comments
5174dae to
9591d0e
Compare
9591d0e to
9768993
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `MobileMenu` component in the `apps/dashboard/src/components/product-pages/common/nav/MobileMenu.tsx` file by replacing the `Drawer` component with a new `Sheet` component for improved UI handling.
### Detailed summary
- Removed `display` prop from `MobileMenu` in `Topnav.tsx`.
- Changed `MobileMenu` from using `useDisclosure` to `useState` for open state management.
- Replaced `Drawer` with `Sheet` for menu display.
- Updated `IconButton` size in `MobileMenu`.
- Adjusted `onItemClick` handlers to close the menu using `setOpen(false)`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
9768993 to
7bfad6e
Compare



Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the
MobileMenucomponent in theapps/dashboard/src/components/product-pages/common/nav/MobileMenu.tsxfile, transitioning from aDrawerto aSheetcomponent for better UI management and state handling.Detailed summary
displayprop fromMobileMenuinTopnav.tsx.MobileMenufrom usinguseDisclosuretouseStatefor open state management.DrawerwithSheetfor displaying the mobile menu.IconButtonsize inMobileMenu.onItemClickto close the menu usingsetOpen(false).