[Dashboard] Remove react-icons (2) #5006
Merged
+28
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5006 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1058 1058
Lines 54670 54670
Branches 3950 3950
=======================================
Hits 24757 24757
Misses 29222 29222
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
This was referenced Oct 14, 2024
MananTank
approved these changes
Oct 14, 2024
kien-ngo
force-pushed
the
kien/remove-react-icons-1
branch
from
c21d388 to
e800622
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
4305d6e to
a3b72d2
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-1
branch
from
e800622 to
5d66828
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-2
branch
from
a3b72d2 to
0537c35
Compare
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating various components to replace icon imports from `react-icons` with icons from `lucide-react`. Additionally, it modifies the icon usage in several tables to enhance the UI consistency.
### Detailed summary
- Replaced `BsArrowRight` with `MoveRightIcon` in `RelevantDataSection`.
- Updated trash icons from `FiTrash` to `Trash2Icon` in:
- `KeypairsTable`
- `WebhooksTable`
- `ContractSubscriptionTable`
- `AdminsTable`
- `EngineInstancesTable`
- `RelayersTable`
- `AccessTokensTable`
- `BackendWalletsTable`
- Added `PencilIcon` in `AdminsTable`, `EngineInstancesTable`, `RelayersTable`, and `AccessTokensTable` for edit actions.
- Adjusted icon rendering to JSX syntax (`<IconName />`) for consistency across tables.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
kien/remove-react-icons-1
branch
from
5d66828 to
f6cf5b5
Compare
jnsdls
force-pushed
the
kien/remove-react-icons-2
branch
from
0537c35 to
d6f2acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR primarily focuses on updating icon imports and usages throughout various components in the dashboard application, replacing older icon libraries with
lucide-reacticons for consistency and improved visuals.Detailed summary
react-iconsicons withlucide-reacticons in multiple components.RelevantDataSectionto useMoveRightIcon.KeypairsTable,WebhooksTable,ContractSubscriptionTable,AdminsTable,EngineInstancesTable,RelayersTable,AccessTokensTable, andBackendWalletsTableto useTrash2IconandPencilIcon.react-icons.