-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Marketplace Listing drawer -> Sheet #5008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5008 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1058 1058
Lines 54670 54670
Branches 3950 3950
=======================================
Hits 24757 24757
Misses 29222 29222
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
apps/dashboard/src/contract-ui/tabs/shared-components/listing-drawer.tsx
Outdated
Show resolved
Hide resolved
MananTank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address comments
a898777 to
24b1add
Compare
8a6e419 to
47e80b4
Compare
24b1add to
8f03ab5
Compare
47e80b4 to
8509e0d
Compare
8f03ab5 to
d8999e6
Compare
8509e0d to
0c6d85e
Compare
d8999e6 to
7e2ed42
Compare
Merge activity
|
0c6d85e to
2e6361c
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR refactors the `ListingDrawer` component by replacing the `Drawer` component with the `Sheet` component, streamlining the layout and improving the structure of the user interface.
### Detailed summary
- Removed `Drawer` component and replaced it with `Sheet` and `SheetContent`.
- Adjusted properties for `Sheet` to manage open state and layout.
- Updated class names for `SheetContent` to maintain styling consistency.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
7e2ed42 to
44b2634
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the
ListingDrawercomponent by replacing theDrawercomponent with aSheetcomponent for improved UI layout and functionality.Detailed summary
Drawercomponent with theSheetcomponent.SheetContentfor layout.allowPinchZoom,preserveScrollBarGap, andsizeprops from theDrawer.SheetContent.