[Dashboard] Marketplace Listing drawer -> Sheet #5008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 14, 2024
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5008 +/- ##
=======================================
Coverage 45.28% 45.28%
=======================================
Files 1058 1058
Lines 54670 54670
Branches 3950 3950
=======================================
Hits 24757 24757
Misses 29222 29222
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
MananTank
reviewed
Oct 14, 2024
apps/dashboard/src/contract-ui/tabs/shared-components/listing-drawer.tsx
Outdated
Show resolved
Hide resolved
kien-ngo
force-pushed
the
kien/listing-drawer-to-sheet
branch
from
a898777 to
24b1add
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-3
branch
from
8a6e419 to
47e80b4
Compare
kien-ngo
force-pushed
the
kien/listing-drawer-to-sheet
branch
from
24b1add to
8f03ab5
Compare
kien-ngo
force-pushed
the
kien/remove-react-icons-3
branch
from
47e80b4 to
8509e0d
Compare
kien-ngo
force-pushed
the
kien/listing-drawer-to-sheet
branch
from
8f03ab5 to
d8999e6
Compare
jnsdls
approved these changes
Oct 15, 2024
kien-ngo
force-pushed
the
kien/remove-react-icons-3
branch
from
8509e0d to
0c6d85e
Compare
kien-ngo
force-pushed
the
kien/listing-drawer-to-sheet
branch
from
d8999e6 to
7e2ed42
Compare
Contributor
Merge activity
|
jnsdls
force-pushed
the
kien/remove-react-icons-3
branch
from
0c6d85e to
2e6361c
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR refactors the `ListingDrawer` component by replacing the `Drawer` component with the `Sheet` component, streamlining the layout and improving the structure of the user interface.
### Detailed summary
- Removed `Drawer` component and replaced it with `Sheet` and `SheetContent`.
- Adjusted properties for `Sheet` to manage open state and layout.
- Updated class names for `SheetContent` to maintain styling consistency.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
kien/listing-drawer-to-sheet
branch
from
7e2ed42 to
44b2634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the
ListingDrawercomponent by replacing theDrawercomponent with aSheetcomponent for improved UI layout and functionality.Detailed summary
Drawercomponent with theSheetcomponent.SheetContentfor layout.allowPinchZoom,preserveScrollBarGap, andsizeprops from theDrawer.SheetContent.