-
Notifications
You must be signed in to change notification settings - Fork 619
[Documentation] Refactor: Update tsdoc references #5374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0e5d120 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
7433ee2 to
3358248
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
==========================================
- Coverage 45.49% 43.81% -1.69%
==========================================
Files 1070 1069 -1
Lines 55770 55726 -44
Branches 4034 3882 -152
==========================================
- Hits 25372 24415 -957
- Misses 29711 30628 +917
+ Partials 687 683 -4
*This pull request uses carry forward flags. Click here to find out more.
|
3358248 to
ee1f72f
Compare
d491dd9 to
bfca532
Compare
5dbcd4e to
3fc2ea5
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on refactoring the `NFT` component and its related functionalities to improve performance, enhance control over fetching logic, and simplify usage by removing the need for `React.Suspense`. It also introduces new props for better loading and error handling.
### Detailed summary
- Deleted several test files and an unused `NFT.tsx` file.
- Introduced `NFTProvider`, `NFTMedia`, `NFTName`, and `NFTDescription` components.
- Added `loadingComponent` and `fallbackComponent` props for better handling of loading states and errors.
- Updated references in tests to use new component structure.
- Renamed and adjusted documentation comments to reflect new functionality.
- Improved sidebar organization by updating links and names for consistency.
- Enhanced utility functions and hooks for better NFT data fetching and context management.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
3fc2ea5 to
0e5d120
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
NFTcomponent and its related functionalities in thethirdweblibrary, introducing new props for better loading and fallback handling, and refining the overall structure and documentation of various components.Detailed summary
NFTand wallet integration.NFTcomponent structure to useNFTProviderfor context management.loadingComponentandfallbackComponentprops inNFTMedia,NFTName, andNFTDescription.