feat(notifications): add in-app notification scaffold and host#9628
Merged
rafaeltonholo merged 4 commits intothunderbird:mainfrom Sep 5, 2025
Conversation
rafaeltonholo
force-pushed
the
feat/9312/add-in-app-notification-host-and-scaffold
branch
from
6eada3f to
4c63c91
Compare
rafaeltonholo
force-pushed
the
feat/9312/add-in-app-notification-host-and-scaffold
branch
5 times, most recently
from
64b29e6 to
b433ff7
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
force-pushed
the
feat/9312/add-in-app-notification-host-and-scaffold
branch
2 times, most recently
from
f22599c to
7a56883
Compare
asoucar
requested changes
Sep 5, 2025
.../kotlin/net/thunderbird/feature/notification/api/ui/host/InAppNotificationHostStateHolder.kt
Outdated
Show resolved
Hide resolved
...androidUnitTest/kotlin/net/thunderbird/feature/notification/api/ui/util/PrintSemanticTree.kt
Show resolved
Hide resolved
… rememberInAppNotificationHostStateHolder
…ration to enum class
rafaeltonholo
force-pushed
the
feat/9312/add-in-app-notification-host-and-scaffold
branch
from
7a56883 to
5e6857d
Compare
asoucar
approved these changes
Sep 5, 2025
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
deleted the
feat/9312/add-in-app-notification-host-and-scaffold
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9537.
Part of #9312.
Depends on #9624.
InAppNotificationHostused to properly show, hide and dismiss in-app notifications, listening events fromInAppNotificationReceiverInAppNotificationScaffoldacting as a wrapper forScaffoldcomposable, letting any screen which uses it be able to display in-app notifications without many changesSnackbarNotification.durationfromkotlin.time.DurationtoSnackbarDuration, making it compatible with Compose implementation