Skip to content

add repos for sensor_filters#48

Merged
rhaschke merged 8 commits intoubi-agni:mainfrom
knorth55:sensor-filters
Sep 9, 2025
Merged

add repos for sensor_filters#48
rhaschke merged 8 commits intoubi-agni:mainfrom
knorth55:sensor-filters

Conversation

@knorth55
Copy link
Contributor

@knorth55 knorth55 commented Apr 16, 2025

this PR adds sensor_filters and its dependency to ros-o.repos.
I'm checking sensor_filters + robot_body_filter on ROS-O now.

https://github.com/knorth55/ros-builder-action/actions/runs/14539693572

@rhaschke
Copy link
Member

CI is failing for some of these packages.

@knorth55
Copy link
Contributor Author

knorth55 commented Apr 21, 2025

https://github.com/knorth55/ros-builder-action/actions/runs/14581837188

@rhaschke
Copy link
Member

https://github.com/knorth55/ros-builder-action/actions/runs/14581837188

This run didn't build anything as you passed invalid arguments to colcon.

@knorth55
Copy link
Contributor Author

Screenshot 2025-04-22 at 9 30 01

I tried with this configuration, but it does not run anything.
I haven't find how to set colcon package selection correctly yet.
Could you share me how to run it?

@knorth55
Copy link
Contributor Author

knorth55 commented Apr 22, 2025

Also, I added new commits to do these following things, but CI seems not working as expected.

  • exclude ros-utils/tf_static_publisher
    • CI is still building ros-utils/tf_statis_publisher, does not skip the package.
  • add catkin-sphinx in python.repos
    • python packages in python.repos are not update in CI.

Could you give me advice to solve these CI errors?

@rhaschke
Copy link
Member

CI only builds modified packages in ros-one.repos and ignores the known_failures definitions.
There is no chance for you, to fix these CI errors. I was already looking into this PR today, but I'm stuck with issues deploying catkin-sphinx to the repository.

@knorth55
Copy link
Contributor Author

knorth55 commented Apr 22, 2025

I checked several other PRs, and I created another test.repos and checking the CI again.

@knorth55 knorth55 mentioned this pull request Apr 23, 2025
@knorth55
Copy link
Contributor Author

I splitted this PR into #56

@knorth55
Copy link
Contributor Author

I hope both issues are fixed now.
Could you check again? @rhaschke

  • exclude ros-utils/tf_static_publisher
  • add catkin-sphinx in python.repos

@rhaschke rhaschke force-pushed the main branch 3 times, most recently from b0214f8 to 995fe83 Compare August 11, 2025 17:37
@rhaschke rhaschke force-pushed the main branch 3 times, most recently from f8db9e4 to 9dbd3ba Compare September 4, 2025 21:40
@rhaschke rhaschke merged commit 021aab1 into ubi-agni:main Sep 9, 2025
14 checks passed
@knorth55 knorth55 deleted the sensor-filters branch September 10, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants