add missing ref, update to v4 #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
sjmonson
approved these changes
Jul 10, 2025
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
DaltheCow
added a commit
that referenced
this pull request
Jul 15, 2025
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request Signed-off-by: dalthecow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR.
The last UI PR was merged and brought in this buggy ui-unit-test job.
I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3
Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request