Refactor on this day game to use LocalDate #5780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
requested review from
cooltey,
dbrant and
Williamrai
as code owners
cooltey
reviewed
Aug 7, 2025
app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameBaseFragment.kt
Outdated
Show resolved
Hide resolved
* Localisation updates from https://translatewiki.net. * - string fix --------- Co-authored-by: williamrai <[email protected]>
Isira-Seneviratne
force-pushed
the
On-this-day-refactor
branch
from
b1e7270 to
8e83a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Refactors the On This Day game to use
LocalDateinstead of the legacyDateandCalendarclasses.Why is this needed?
It is not recommended to use the older
DateandCalendarclasses.Phabricator:
https://phabricator.wikimedia.org/T...