fix: tags not tappable - WPB-23240#4247
Merged
jullianm merged 2 commits intorelease/cycle-4.14from Feb 4, 2026
Merged
Conversation
Contributor
Test Results2 120 tests 2 093 ✅ 2m 38s ⏱️ Results for commit 883219c. ♻️ This comment has been updated with latest results. Summary: workflow run #21636462361 |
WilhelmOks
approved these changes
Feb 3, 2026
caldrian
approved these changes
Feb 3, 2026
zenkins
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This PR fixes an issue in the tags filter screen where after a pull to refresh, the already presented tags are no longer tappable. Issue is that when selecting a tag after a pull to refresh, the selected tag ID no longer finds a match in the "cached" tags model. Solution is to ensure the presented tags are correctly reset when pulling to refresh so tags IDs are correctly in sync.
Testing
go to Drive tab, open tags filter screen (top right corner), pull to refresh, try to select a tag, then it should select/deselect the tag properly.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: