fix: replace attachment menu with alert - WPB-21656#4272
Merged
jullianm merged 1 commit intorelease/cycle-4.15from Feb 5, 2026
Merged
fix: replace attachment menu with alert - WPB-21656#4272jullianm merged 1 commit intorelease/cycle-4.15from
jullianm merged 1 commit intorelease/cycle-4.15from
Conversation
WilhelmOks
approved these changes
Feb 5, 2026
Contributor
Test Results2 122 tests 2 095 ✅ 4m 15s ⏱️ Results for commit 295881f. Summary: workflow run #21714834610 |
samwyndham
approved these changes
Feb 5, 2026
Contributor
samwyndham
left a comment
There was a problem hiding this comment.
A little bit sad as alerts are quite aggressive but I guess at least it provides space to give reason for the error in the future.
zenkins
pushed a commit
that referenced
this pull request
Feb 5, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This PR replaces the attachment Menu that shows up when a file could not be uploaded as it was introducing a UI bug when the keyboard was showing. As discussed with design team, we prefer to display an alert instead to avoid that bug.
Testing
have an attachment uploaded that ends up in error, tap on the "elipsis" button in top right corner of the attachment. Before it was showing a context menu, now it displays an alert, same actions as before (remove file or retry).
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: