Skip to content

fix: replace attachment menu with alert - WPB-21656#4272

Merged
jullianm merged 1 commit intorelease/cycle-4.15from
fix/replacing-attachment-menu
Feb 5, 2026
Merged

fix: replace attachment menu with alert - WPB-21656#4272
jullianm merged 1 commit intorelease/cycle-4.15from
fix/replacing-attachment-menu

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Feb 5, 2026

TaskWPB-21656 [iOS] Sorting in all files

Issue

This PR replaces the attachment Menu that shows up when a file could not be uploaded as it was introducing a UI bug when the keyboard was showing. As discussed with design team, we prefer to display an alert instead to avoid that bug.

Simulator Screenshot - Snapshots - 2026-02-05 at 15 12 24

Testing

have an attachment uploaded that ends up in error, tap on the "elipsis" button in top right corner of the attachment. Before it was showing a context menu, now it displays an alert, same actions as before (remove file or retry).

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, David-Henner, WilhelmOks, johnxnguyen and samwyndham and removed request for a team February 5, 2026 14:14
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test Results

2 122 tests   2 095 ✅  4m 15s ⏱️
  354 suites     27 💤
    2 files        0 ❌

Results for commit 295881f.

Summary: workflow run #21714834610
Allure report (download zip): html-report-27574-fix_replacing-attachment-menu

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit sad as alerts are quite aggressive but I guess at least it provides space to give reason for the error in the future.

@jullianm jullianm merged commit be47c39 into release/cycle-4.15 Feb 5, 2026
15 checks passed
@jullianm jullianm deleted the fix/replacing-attachment-menu branch February 5, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants