Skip to content

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Jul 24, 2025

  • Tests added
  • Tests passing

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (8230c36) to head (51b54d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          35       35           
  Lines        1848     1848           
=======================================
  Hits         1618     1618           
  Misses        230      230           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomNicholas
Copy link
Member

Is the slow-test actually being run in the CI?

@norlandrhagen norlandrhagen removed the test-slow Run slow tests label Aug 8, 2025
@norlandrhagen
Copy link
Collaborator Author

Two test failures seem to be unrelated and also happening here: https://github.com/zarr-developers/VirtualiZarr/actions/runs/16819018680/job/47642147440

@TomNicholas
Copy link
Member

Yeah 😕 - I raised #761 to track that.

For this PR - how big is that file the test is now pointing to?

@norlandrhagen
Copy link
Collaborator Author

Thanks!

Looks like ~283KB

@maxrjones
Copy link
Member

If we really want to avoid network usage even for small files, we could use minio to test anon s3 access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants