Check integrity of webrtc download in build script #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-miller
force-pushed
the
missing-headers
branch
from
ebfe6fc to
b78f0fc
Compare
cole-miller
force-pushed
the
missing-headers
branch
from
b78f0fc to
2806c15
Compare
cole-miller
added a commit
to zed-industries/zed
that referenced
this pull request
Jul 25, 2025
Let's see if zed-industries/livekit-rust-sdks#6 helps. Release Notes: - N/A --------- Signed-off-by: Cole Miller <cole@zed.dev>
cole-miller
added a commit
that referenced
this pull request
Jul 30, 2025
This reverts commit 383e537.
cole-miller
added a commit
that referenced
this pull request
Jul 30, 2025
Ensure that we download the webrtc release anew each time download_webrtc is called (from either the livekit-ffi build script or the webrtc-sys build script). This is another stab at fixing the build errors we've been seeing in Zed CI, or at least making them easier to understand. Also reverts #6 since it seems the integrity of the downloaded zip was a red herring.
orual
pushed a commit
to orual/zed
that referenced
this pull request
Aug 23, 2025
Let's see if zed-industries/livekit-rust-sdks#6 helps. Release Notes: - N/A --------- Signed-off-by: Cole Miller <cole@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see periodic failures of zed-industries/zed CI when the
ccbuilder in thewebrtc-sysbuild script fails to find some webrtc header files that are supposed to be downloaded using this function:livekit-rust-sdks/webrtc-sys/build/src/lib.rs
Line 179 in d2eade7
This downloads a zip from the assets attached to a specific livekit/rust-sdks release, and unpacks it under OUT_DIR. My guess is that sometimes the download step fails and produces a corrupt downloaded zip, without signaling the failure in a way that would stop the build. This PR tries to fix that by having the download step check the SHA-256 digest of the downloaded zip (using a manually-computed list of good digests; I'd like to use digests from the GitHub API but the particular artifacts we download don't have them).
If we confirm that this is the source of the problem, I'll follow up with a change to retry the download in the build script.