Add PSRAM half Sleep and DCache support for Siwx91x#155
Draft
fimohame wants to merge 4 commits intozephyrproject-rtos:mainfrom
Draft
Add PSRAM half Sleep and DCache support for Siwx91x#155fimohame wants to merge 4 commits intozephyrproject-rtos:mainfrom
fimohame wants to merge 4 commits intozephyrproject-rtos:mainfrom
Conversation
Add d_cache sdk files in import_wiseconnect.py Signed-off-by: S Mohamed Fiaz <Fiaz.Mohamed@silabs.com>
Origin: Silicon Labs WiseConnect SDK License: Zlib and Apache-2.0 URL: https://github.com/siliconlabs/wiseconnect Commit: 74254b81a6fb92f5edfdae037ab4b1d110067db5 Version: v3.5.2 Purpose: Add D_Cache support for SiWx91x Signed-off-by: S Mohamed Fiaz <Fiaz.Mohamed@silabs.com>
fimohame
changed the title
fimohame
requested review from
Martinhoff-maker,
asmellby,
jerome-pouiller and
jhedberg
as code owners
fimohame
changed the title
Martinhoff-maker
requested changes
Nov 27, 2025
wiseconnect/components/device/silabs/si91x/mcu/drivers/unified_api/inc/sl_si91x_psram.h
Outdated
Show resolved
Hide resolved
wiseconnect/components/device/silabs/si91x/mcu/core/chip/src/rsi_deepsleep_soc.c
Outdated
Show resolved
Hide resolved
jerome-pouiller
approved these changes
Nov 28, 2025
wiseconnect/components/device/silabs/si91x/mcu/drivers/unified_api/inc/sl_si91x_psram.h
Outdated
Show resolved
Hide resolved
|
|
||
| #ifdef SLI_SI91X_MCU_ENABLE_PSRAM_FEATURE | ||
| #include "sl_si91x_psram.h" | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Unless the target file does not exist, avoid conditionally include the header files (unused declarations don't hurt the code).
| #error "No valid PSRAM configuration defined" | ||
| #endif | ||
|
|
||
| #endif |
Collaborator
There was a problem hiding this comment.
Maybe this is the right place for the Zephyr configuration:
- Add the various macro based on the DT in
sl_si91x_psram_zephyr_config.h - Include this file if
__ZEPHYR__is defined:
#if defined(SLI_SI91X_MCU_PSRAM_APS1604M_SQR)
...
#elif __ZEPHYR__
#include "sl_si91x_psram_zephyr_config.h"
#endif
| #error "No valid PSRAM configuration defined" | ||
| #endif | ||
|
|
||
| #endif |
wiseconnect/components/device/silabs/si91x/mcu/drivers/unified_api/inc/sl_si91x_psram.h
Outdated
Show resolved
Hide resolved
Included sl_si91x_psram.h under __ZEPHYR__ guard to ensure compatibility with Zephyr builds. Signed-off-by: S Mohamed Fiaz <Fiaz.Mohamed@silabs.com>
fimohame
force-pushed
the
siwx91x-psram-half-sleep-support
branch
from
24254e3 to
56aebc9
Compare
Applied __ZEPHYR__ guards around PSRAM configuration and related includes to restrict PSRAM-specific code to non-Zephyr builds. Signed-off-by: S Mohamed Fiaz <Fiaz.Mohamed@silabs.com>
fimohame
force-pushed
the
siwx91x-psram-half-sleep-support
branch
from
56aebc9 to
97f48c6
Compare
| #include "sl_si91x_psram_aps6404l_sqh_config.h" | ||
| #elif defined(SLI_SI91X_MCU_PSRAM_APS6404L_SQRH) | ||
| #include "sl_si91x_psram_aps6404l_sqrh_config.h" | ||
| #elif __ZEPHYR__ |
Member
There was a problem hiding this comment.
I understand this patch but is there any actions to take in Wiseconnect in order to avoid that stuff in the next release of Wiseconnect ? Remenber that @jerome-pouiller is trying to reduce the number of patch in wiseconnect so each time we introduce a new one, we should think to remove it in the next release.
Contributor
Author
There was a problem hiding this comment.
let me check through if we can do any in here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Origin: Silicon Labs WiseConnect SDK
License: Zlib and Apache-2.0
URL: https://github.com/siliconlabs/wiseconnect
Commit: 74254b81a6fb92f5edfdae037ab4b1d110067db5
Version: v3.5.2
Purpose: Add PSRAM half sleep mode support.
This functionality enables low-power operations for
PSRAM half sleep supported devices.
Signed-off-by: S Mohamed Fiaz Fiaz.Mohamed@silabs.com