tests: Bluetooth: Classic: Add test suites gap_discovery

[lylezhu2012]

Add test cases gap_central.test_01_gap_central_general_discovery and gap_central.test_02_gap_central_limited_discovery.

Add test cases gap_peripheral.test_01_gap_peripheral_general_discovery and gap_peripheral.test_02_gap_peripheral_limited_discovery.

[Copilot]

Pull request overview

This PR adds comprehensive test suites for Bluetooth Classic GAP (Generic Access Profile) discovery functionality, testing both general and limited discovery modes for central and peripheral roles.

• Implements test cases for GAP central device performing discovery operations
• Implements test cases for GAP peripheral device advertising and being discovered
• Adds automation script to orchestrate two-device testing using virtual Bluetooth controllers

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
tests/bluetooth/classic/gap_discovery/tests_scripts/gap_discovery_run.sh	Bash script that sets up virtual HCI devices, builds and runs both central and peripheral test executables
tests/bluetooth/classic/gap_discovery/testcase.yaml	Test configuration defining platform support (native_sim), tags, timeout, and harness type
tests/bluetooth/classic/gap_discovery/src/test_peripheral.c	Peripheral role test implementation with general and limited discovery test cases
tests/bluetooth/classic/gap_discovery/src/test_central.c	Central role test implementation with general and limited discovery test cases
tests/bluetooth/classic/gap_discovery/prj.conf	Project configuration enabling Bluetooth Classic, logging, and test-specific settings
tests/bluetooth/classic/gap_discovery/README.rst	Documentation describing test purpose, requirements, building/running instructions, and sample output
tests/bluetooth/classic/gap_discovery/Kconfig	Configuration options for GAP role selection and device address configuration
tests/bluetooth/classic/gap_discovery/CMakeLists.txt	Build configuration conditionally including central or peripheral test sources based on Kconfig

Comments suppressed due to low confidence (2)

tests/bluetooth/classic/gap_discovery/tests_scripts/gap_discovery_run.sh:238

• Shell command execution issue: The build command is stored as a string and then executed directly with $build_cmd. This approach doesn't properly handle the command with its arguments and quoted parameters. Use eval $build_cmd instead to properly execute the command string, or better yet, execute the command directly without storing it in a variable:

if ! west build -b native_sim tests/bluetooth/classic/gap_discovery -d "$build_dir" -DCONFIG_TEST_GAP_PERIPHERAL=y -DCONFIG_TEST_GAP_CENTRAL_ADDRESS=\"${virtual_addresses[1]}\"; then

    if ! $build_cmd; then

tests/bluetooth/classic/gap_discovery/tests_scripts/gap_discovery_run.sh:369

• Shell command execution issue: The build command is stored as a string and then executed directly with $build_cmd. This approach doesn't properly handle the command with its arguments and quoted parameters. Use eval $build_cmd instead to properly execute the command string, or better yet, execute the command directly without storing it in a variable.

    if ! $build_cmd; then

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The script runs sudo commands for btvirt, btmon, hciconfig, and test executables without checking if the user has sudo privileges. If sudo requires a password or fails, the script may hang or fail unexpectedly. Consider adding a sudo privilege check at the beginning or handling sudo failures more gracefully.

[lylezhu2012]

Hi @jhedberg , This PR is used to add a new test suite for Bluetooth Classic in simulation platform and simulation controller. My goal is for it to become part of CI/CV for Bluetooth Classic PR inspection.

What do I need to do to achieve this goal?

[jhedberg]

Why such an old version of the SDK? The latest one is 0.17.4. You might also want to factor out the version to a single updatable variable, and maybe also consider using the west sdk install command.

[lylezhu2012]

Thanks. Will update it.

[sonarqubecloud]

Quality Gate passed

Issues
31 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud