refactor devicetree binding support for JESD216 devices #31042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
|
CI failure is #31044, not related to this PR. |
jfischer-no
reviewed
Dec 29, 2020
arvid-r
approved these changes
Dec 29, 2020
pabigot
force-pushed
the
nordic/20201229a
branch
from
be3009c to
0051093
Compare
jfischer-no
approved these changes
Dec 30, 2020
erwango
approved these changes
Jan 4, 2021
MaureenHelm
approved these changes
Jan 4, 2021
Use of this property has no effect since it was by SFDP erase data in Zephyr 2.4. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20201229a
branch
from
0051093 to
5ae472f
Compare
|
Rebased now that CI build failure has been fixed (#31044). |
|
@galak any input? |
zephyrbot
requested review from
katsuster,
mbolivar-nordic,
mgielda and
nategraff-sifive
galak
reviewed
Jan 12, 2021
dts/bindings/mtd/jedec,jesd216.yaml
Outdated
There was a problem hiding this comment.
should we add deprecated: true here?
galak
reviewed
Jan 12, 2021
jedec,jesd216.yaml has properties for any memory device that conforms to the JESD216 specification. This file at a minimum should be included in the binding for any driver that interacts with such a device. jedec,spi-nor-common.yaml extends jedec,jesd216 with additional parameters useful for memory devices that are not available from standard JESD216 parameter tables. This file may be included instead of jedec,jesd216.yaml if a driver is able to support additional functionality related to the extended description. jedec,spi-nor.yaml remains the binding for the Zephyr SPI_NOR driver alone. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20201229a
branch
from
5ae472f to
92a75a8
Compare
Wasn't thinking about that, added it now. |
galak
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JESD216 specifies serial flash discoverable parameters used by various flash memory devices. Historically the only Zephyr driver for these devices was the one that became
SPI_NOR. Subsequently Nordic introduced a QSPI driver that required some of the parameters, but not others. This introduced a split so the shared properties could be described once and used in multiple driver-specific bindings.Now there are additional QSPI drivers being proposed for different SOCs, including #30864 and #31034. #30864 includes a commit to further split the shared properties by eliminating ones that aren't supported by a driver.
I'd like to see that split discussed and merged separately so that all QSPI rework in progress (including Nordic) can use it. Hence this PR, which is much the same as the one from @erwango in #30864 but adds documentation explaining what goes in which layer, and takes steps towards removing a legacy property.