[Backport v2.7-branch] kernel shell, stacks shell commands: always use k_thread_foreach_unlocked #64658
Conversation
call k_thread_foreach_unlocked to avoid assertions caused by calling shell_print while holding a global lock Signed-off-by: Maxim Adelman <[email protected]> (cherry picked from commit ecf2cb5)
jhedberg
changed the title
|
@jakub-uC - I think this one might require your approval |
|
@jakub-uC - just a gentle ping again. Does this backport look OK to you? |
There was a problem hiding this comment.
Actually, upon revisiting this, I think we need to exclusively use the unlocked variant here, which would mirror main.
zephyr/subsys/shell/modules/kernel_service.c
Line 201 in ebbf672
|
@finikorg - would you be able to do perform the necessary rework? |
Is backport assumes we backport existing changes only? |
Yeah, technically, I guess that's the case - so maybe cherry-picking multiple commits would be better. |
cfriedt
changed the title
|
4c731f2 has been cherry-picked on top of the original commit which reflects what is in |
Always use k_thread_foreach_unlocked with callbacks which print something out to the shell, as they might call arch_irq_unlock. Fixes #66660. Signed-off-by: Benedikt Schmidt <[email protected]> (cherry picked from commit 4c731f2)
cfriedt
force-pushed
the
backport-59244-to-v2.7-branch
branch
from
dd63f90 to
1d73bfa
Compare
6 participants
call k_thread_foreach_unlocked to avoid assertions caused by calling shell_print while holding a global lock
Fixes #32145