Skip to content

[Backport v2.7-branch] kernel shell, stacks shell commands: always use k_thread_foreach_unlocked #64658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2024
+13 −2
Merged

[Backport v2.7-branch] kernel shell, stacks shell commands: always use k_thread_foreach_unlocked #64658

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ff36f
kernel shell, stacks shell commands: iterate unlocked on SMP
Jun 14, 2023
1d73bfa
shell: modules: do not use k_thread_foreach with shell callbacks
benediktibk Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions subsys/shell/modules/kernel_service.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,12 @@ static int cmd_kernel_threads(const struct shell *shell,

shell_print(shell, "Scheduler: %u since last call", sys_clock_elapsed());
shell_print(shell, "Threads:");

#ifdef CONFIG_SMP
k_thread_foreach_unlocked(shell_tdata_dump, (void *)shell);
#else
k_thread_foreach(shell_tdata_dump, (void *)shell);
#endif
return 0;
}

Expand Down Expand Up @@ -184,7 +189,12 @@ static int cmd_kernel_stacks(const struct shell *shell,

ARG_UNUSED(argc);
ARG_UNUSED(argv);

#ifdef CONFIG_SMP
k_thread_foreach_unlocked(shell_stack_dump, (void *)shell);
#else
k_thread_foreach(shell_stack_dump, (void *)shell);
#endif

/* Placeholder logic for interrupt stack until we have better
* kernel support, including dumping arch-specific exception-related
Expand Down