Skip to content

Add support for icm42686 and tune for NXP VMURT1170 #75187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add support for icm42686 and tune for NXP VMURT1170 #75187

wants to merge 3 commits into from

Conversation

@sumitbatra-nxp
Copy link
Contributor

@sumitbatra-nxp sumitbatra-nxp commented Jun 28, 2024 •
edited
Loading

  1. Support both icm42688 and icm42686 through the same driver
  2. Add support for setting Anti Alias Filter for Accelerometer and Gyroscope
  3. Tune icm4268x sensors for VMURT1170 for NXP's Mobile Robotics
    products

@zephyrbot zephyrbot added area: Sensors Sensors area: Samples Samples platform: NXP NXP area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jun 28, 2024
@teburd teburd added this to the v4.0.0 milestone Jul 16, 2024
This was referenced Jul 16, 2024
Merged
Closed
decsny
decsny previously requested changes Jul 22, 2024
View reviewed changes
@teburd
Copy link
Contributor

teburd commented Jul 24, 2024

Please split up the first commit into a few commits...

  1. renaming icm42688 to icm4268x and adding the additional 686 compatible
  2. Adding additional dt config options
  3. Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.

@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Jul 24, 2024

Please split up the first commit into a few commits...

  1. renaming icm42688 to icm4268x and adding the additional 686 compatible
  2. Adding additional dt config options
  3. Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.
@teburd
There is no real use of the sample app, I just wrote it for my testing and kept it as is.
Please suggest if you want me to remove it.

@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Jul 29, 2024

Please split up the first commit into a few commits...

  1. renaming icm42688 to icm4268x and adding the additional 686 compatible
  2. Adding additional dt config options
  3. Adding sample app (I'm not entirely convinced of this? whats special about this sample?)

The last commit modifying the vmu board dts seems ok to me.

@teburd .. Created the commits as per your suggestion.. Please check now

decsny
decsny reviewed Jul 29, 2024
View reviewed changes
decsny
decsny reviewed Jul 30, 2024
View reviewed changes
@sumitbatra-nxp sumitbatra-nxp requested a review from decsny July 31, 2024 18:33
decsny
decsny reviewed Jul 31, 2024
View reviewed changes
@teburd
Copy link
Contributor

teburd commented Jul 31, 2024

Will review once CI passes

decsny
decsny reviewed Jul 31, 2024
View reviewed changes
@decsny decsny dismissed their stale review August 14, 2024 20:27

removing block because I am having a hard time tracking so many PRs, although comment still needs addressed, so please update that

sumitbatra-nxp and others added 3 commits August 23, 2024 17:38
@sumitbatra-nxp @mayankmahajan-nxp
sensor: tdk: Add support for icm42686
a68790c 
Support both icm42686 and icm42688 through the same driver

Co-authored-by: Mayank Mahajan <[email protected]>
Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp
sensor: tdk: Additional dt options for icm4268x
598cc23 
Add Filters for Accelerometer and Gyroscope and other dt options

Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp @mayankmahajan-nxp
boards: nxp: Tune icm4286x sensors for VMURT7
ac8ee42 
Populate vmu_rt1170 board dts file with default settings for icm42688
and icm42686.

Co-authored-by: Mayank Mahajan <[email protected]>
Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp sumitbatra-nxp requested a review from decsny August 23, 2024 15:57
@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Aug 23, 2024

@teburd .. Please review..

@teburd
Copy link
Contributor

teburd commented Aug 23, 2024

@bperseghetti do take a look if you can

@teburd
Copy link
Contributor

teburd commented Aug 23, 2024 •
edited
Loading

Approved as code changes look good, but I'm marking DNM until people have a chance to test this out on hardware, as it is a pretty big change. I'll try and test it out next week.

@teburd teburd added the DNM This PR should not be merged (Do Not Merge) label Aug 23, 2024
@decsny decsny added the block: HW Test Testing on hardware required before merging label Aug 24, 2024
@nxp-zephyr nxp-zephyr closed this by deleting the head repository Aug 26, 2024
@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Aug 26, 2024

@teburd .. The source repo is deleted due to some internal policy related issues.. but please continue your testing.. I'll raise it from another Repo and link it to this one

@sumitbatra-nxp sumitbatra-nxp mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@decsny decsny decsny approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@galak galak Awaiting requested review from galak

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@kartben kartben Awaiting requested review from kartben

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@tristan-google tristan-google Awaiting requested review from tristan-google

@ubieda ubieda Awaiting requested review from ubieda

@yperess yperess Awaiting requested review from yperess

Assignees

@MaureenHelm MaureenHelm

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples area: Sensors Sensors block: HW Test Testing on hardware required before merging DNM This PR should not be merged (Do Not Merge) platform: NXP NXP

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@sumitbatra-nxp @teburd @decsny @MaureenHelm @zephyrbot @nxp-zephyr