boards: adafruit: add initial support for esp32s3 feather #75844

leonrinkel · 2024-07-13T15:23:19Z

This PR adds board support for the Adafruit Feather ESP32S3 development board. This is basically a copy of the Espressif ESP32-S3-DevKitC board, adapted to accommodate the board-specific features of the Adafruit board, i.e. pinout, feather connector, fuel gauge and on-board NeoPixel. There is an issue #68512 requesting support for this board.

github-actions · 2024-07-13T15:23:59Z

Hello @leonrinkel, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

leonrinkel · 2024-07-30T19:35:10Z

Rebased on latest main and resized board image to please CI compliance checks.

kartben · 2024-08-01T16:14:42Z

@leonrinkel your name sounds familiar 😄

boards/adafruit/feather_esp32s3/doc/index.rst

zpm1066 · 2024-08-12T16:39:01Z

@leonrinkel Hi,
Is there any chance of also adding support for the Adafruit ESP32S3 TFT Feather (https://www.adafruit.com/product/5483)?

This board is identical to the Feather ESP32S3 but has a built-in ST7789 135x240 display that has TFT/I2C power controlled by a GPIO.

I’ve been using both boards with esp32s3_devkitc (and esp32s3_devkitm) and external ST7789 but haven’t been able to get the built-in display to work by turning on the TFT power using GPIO hog.

leonrinkel · 2024-08-12T19:45:07Z

@zpm1066 I ordered one and will have a look once it arrives 👍

leonrinkel · 2024-08-14T19:13:10Z

Ok I managed to get the TFT working and will extend this PR in the coming days. Now that I'm at it, I also got the PSRAM and reverse TFT variants to make sure they'll work too.

zpm1066 · 2024-08-30T00:22:52Z

@leonrinkel Were you able to test out the Adafruit Feather PSRAM and reverse TFT board variants?
Any chance of extending the PR in the next week or so? Thanks.

sylvioalves · 2024-12-17T19:08:36Z

boards/adafruit/feather_esp32s3/doc/index.rst

ESP32 -> ESP32-S3
Please apply this change elsewhere accordingly.

boards/adafruit/feather_esp32s3/doc/index.rst

sylvioalves · 2024-12-17T19:14:28Z

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_appcpu.dts

#include <espressif/esp32s3/esp32s3_wroom_n8.dtsi>
#include <adafruit_qt_py_esp32s3-pinctrl.dtsi>

sylvioalves · 2024-12-17T19:15:39Z

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_procpu.yaml

As before, let this go.

boards/adafruit/feather_esp32s3_tft/doc/index.rst

sylvioalves · 2024-12-27T18:06:04Z

boards/adafruit/feather_esp32s3/adafruit_feather_esp32s3_procpu.dts

Make it sram1 instead: zephyr,sram = &sram1;

sylvioalves · 2024-12-27T18:06:30Z

boards/adafruit/feather_esp32s3/adafruit_feather_esp32s3_appcpu.dts

Make it sram1 instead: zephyr,sram = &sram1;

sylvioalves · 2024-12-27T18:11:19Z

boards/adafruit/feather_esp32s3_tft/Kconfig

Please move all the below to Kconfig.defconfig file instead.

if BOARD_ADAFRUIT_FEATHER_ESP32S3_TFT_ESP32S3_PROCPU

sylvioalves · 2024-12-27T18:12:44Z

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_appcpu.dts

Same as before: sram1

sylvioalves · 2024-12-27T18:13:01Z

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_procpu.dts

Same as before: sram1

The Adafruit Feather ESP32S3 is a development board in the Feather standard layout, sharing peripheral placement with other devices labeled as Feathers or FeatherWings. The board is equipped with an ESP32-S3 mini module, a lithium ion battery charger and a USB-C connector. Signed-off-by: Leon Rinkel <[email protected]>

The Adafruit Feather ESP32S3 is a development board in the Feather standard layout, sharing peripheral placement with other devices labeled as Feathers or FeatherWings. The board is equipped with an ESP32-S3 mini module, a lithium ion battery charger and a USB-C connector. Compared to the base model, this TFT variant additionally comes with a 240x135 pixel IPS TFT color display. Signed-off-by: Leon Rinkel <[email protected]>

simonguinot · 2025-01-06T14:48:32Z

samples/drivers/led/led_strip/boards/adafruit_feather_esp32s3_procpu.conf

+CONFIG_POWER_DOMAIN=y
+CONFIG_GPIO=y
+CONFIG_PM_DEVICE=y
+CONFIG_PM_DEVICE_POWER_DOMAIN=y


Is all this necessary to demonstrate the led-strip driver on this board ? For example, I can see that CONFIG_GPIO is already enabled in the board defconfig and as far I can tell it is not a dependency of the WS2812 LED strip driver...

github-actions · 2025-03-08T00:29:49Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

please revisit

github-actions · 2025-03-14T16:53:59Z

Hi @leonrinkel!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

leonrinkel force-pushed the board/adafruit-feather-esp32s3 branch from 7169507 to a4de851 Compare July 15, 2024 14:12

leonrinkel marked this pull request as ready for review July 15, 2024 14:14

zephyrbot added area: LED Label to identify LED subsystem area: Samples Samples labels Jul 15, 2024

zephyrbot requested review from Mani-Sadhasivam, bbilas, kartben, nashif and simonguinot July 15, 2024 14:14

zephyrbot assigned kartben Jul 15, 2024

leonrinkel force-pushed the board/adafruit-feather-esp32s3 branch from a4de851 to 2c7644b Compare July 30, 2024 19:33

kartben added platform: ESP32 Espressif ESP32 and removed area: LED Label to identify LED subsystem area: Samples Samples labels Aug 1, 2024

kartben requested review from LucasTambor, marekmatej, sylvioalves and uLipe August 1, 2024 16:15

kartben assigned sylvioalves and unassigned kartben Aug 1, 2024

uLipe previously approved these changes Aug 1, 2024

View reviewed changes

uLipe reviewed Aug 1, 2024

View reviewed changes

boards/adafruit/feather_esp32s3/doc/index.rst Outdated Show resolved Hide resolved

marekmatej previously approved these changes Aug 6, 2024

View reviewed changes

sylvioalves reviewed Dec 17, 2024

View reviewed changes

boards/adafruit/feather_esp32s3/doc/index.rst Outdated Show resolved Hide resolved

sylvioalves reviewed Dec 17, 2024

View reviewed changes

boards/adafruit/feather_esp32s3_tft/doc/index.rst Outdated Show resolved Hide resolved

leonrinkel force-pushed the board/adafruit-feather-esp32s3 branch 4 times, most recently from be7c1ce to 6634bc7 Compare December 27, 2024 14:37

sylvioalves reviewed Dec 27, 2024

View reviewed changes

boards/adafruit/feather_esp32s3/adafruit_feather_esp32s3_procpu.dts Outdated

Copy link

Contributor

sylvioalves Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it sram1 instead: zephyr,sram = &sram1;

sylvioalves reviewed Dec 27, 2024

View reviewed changes

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_appcpu.dts Outdated

Copy link

Contributor

sylvioalves Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before: sram1

sylvioalves reviewed Dec 27, 2024

View reviewed changes

boards/adafruit/feather_esp32s3_tft/adafruit_feather_esp32s3_tft_procpu.dts Outdated

Copy link

Contributor

sylvioalves Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before: sram1

leonrinkel added 2 commits December 28, 2024 22:35

leonrinkel force-pushed the board/adafruit-feather-esp32s3 branch from 6634bc7 to cbd9d61 Compare December 28, 2024 22:03

sylvioalves approved these changes Dec 30, 2024

View reviewed changes

uLipe approved these changes Jan 2, 2025

View reviewed changes

simonguinot reviewed Jan 6, 2025

View reviewed changes

This was referenced Feb 6, 2025

board: Adafruit ESP32-S2 Feather #85313

Closed

boards: adafruit: esp32s2_feather: add support #85405

Merged

github-actions bot added the Stale label Mar 8, 2025

nashif removed the Stale label Mar 13, 2025

kartben merged commit b5cd22e into zephyrproject-rtos:main Mar 14, 2025
21 checks passed

lvoytek mentioned this pull request Mar 16, 2025

boards: adafruit: add initial support for esp32 feather v2 #87177

Merged

kartben linked an issue May 22, 2025 that may be closed by this pull request

Add Support for Adafruit ESP32-S3 and ESP32-S2 Feather Boards #68512

Closed

boards: adafruit: add initial support for esp32s3 feather #75844

boards: adafruit: add initial support for esp32s3 feather #75844

Uh oh!

Conversation

leonrinkel commented Jul 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 13, 2024

Uh oh!

leonrinkel commented Jul 30, 2024

Uh oh!

kartben commented Aug 1, 2024

Uh oh!

Uh oh!

zpm1066 commented Aug 12, 2024

Uh oh!

leonrinkel commented Aug 12, 2024

Uh oh!

leonrinkel commented Aug 14, 2024

Uh oh!

zpm1066 commented Aug 30, 2024

Uh oh!

sylvioalves Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sylvioalves Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 8, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

leonrinkel commented Jul 13, 2024 •

edited

Loading

sylvioalves Dec 17, 2024 •

edited

Loading

sylvioalves Dec 27, 2024 •

edited

Loading