drivers: dma_mcux_edma: utilize correct macros for edma v3 #81193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize correct macros for edma v3 Signed-off-by: Dat Nguyen Duy <[email protected]>
Dat-NguyenDuy
requested review from
dleach02 and
mmahadevan108
as code owners
zephyrbot
added
area: DMA
zephyrbot
requested review from
MarkWangChinese,
danieldegrasse,
dbaluta,
decsny,
manuargue and
teburd
Contributor
Author
|
Hi @mmahadevan108 @dleach02, Is there a possibility of including this fix in Zephyr v4.0.0? |
Member
|
@mmahadevan108 @dkalowsk note there is 9 failures in weekly with this issue, and the fix is quite trivial. |
dleach02
approved these changes
Nov 11, 2024
dleach02
added
the
Trivial
Member
|
Given that this is a regression failure, I marked the issue as regression and high. |
teburd
approved these changes
Nov 11, 2024
Raymond0225
reviewed
Nov 12, 2024
| #endif /* CONFIG_DMA_MCUX_EDMA_V3 */ | ||
| #elif defined(CONFIG_DMA_MCUX_EDMA_V4) | ||
| /* Above macros have been defined in fsl_edma_core.h */ | ||
| #define EDMA_HW_TCD_CH_ACTIVE_MASK (DMA_CH_CSR_ACTIVE_MASK) |
Contributor
There was a problem hiding this comment.
As this macro is defined exactly same for V3 and V4, It is better to move it to below HW TCD macro definitions, so we don't need to duplicate it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize correct macros for edma v3.
This fixes: #81171