Skip to content

drivers: dma_mcux_edma: utilize correct macros for edma v3 #81193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

drivers: dma_mcux_edma: utilize correct macros for edma v3 #81193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions drivers/dma/dma_mcux_edma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@
#define EDMA_TCD_CITER(tcd, flag) ((tcd)->CITER)
#define EDMA_TCD_CSR(tcd, flag) ((tcd)->CSR)
#define EDMA_TCD_DLAST_SGA(tcd, flag) ((tcd)->DLAST_SGA)
#if defined(CONFIG_DMA_MCUX_EDMA_V3)
#define DMA_CSR_DREQ DMA_TCD_CSR_DREQ
#define EDMA_HW_TCD_CH_ACTIVE_MASK (DMA_CH_CSR_ACTIVE_MASK)
#else

Check notice on line 152 in drivers/dma/dma_mcux_edma.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/dma/dma_mcux_edma.c:152 
-#define DMA_CSR_DREQ                  DMA_TCD_CSR_DREQ
-#define EDMA_HW_TCD_CH_ACTIVE_MASK    (DMA_CH_CSR_ACTIVE_MASK)
+#define DMA_CSR_DREQ               DMA_TCD_CSR_DREQ
+#define EDMA_HW_TCD_CH_ACTIVE_MASK (DMA_CH_CSR_ACTIVE_MASK)
#define EDMA_HW_TCD_CH_ACTIVE_MASK (DMA_CSR_ACTIVE_MASK)
#endif /* CONFIG_DMA_MCUX_EDMA_V3 */
#elif defined(CONFIG_DMA_MCUX_EDMA_V4)
/* Above macros have been defined in fsl_edma_core.h */
#define EDMA_HW_TCD_CH_ACTIVE_MASK (DMA_CH_CSR_ACTIVE_MASK)
Copy link
Contributor

@Raymond0225 Raymond0225 Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this macro is defined exactly same for V3 and V4, It is better to move it to below HW TCD macro definitions, so we don't need to duplicate it here.

Expand Down
Loading