boards: added the Sensoan SGW-2 board

[Rautanyrkki]

Added the sensoan/sgw2 board
Added 'sensoan Sensoan Oy' to vendor-prefixes.txt

[Rautanyrkki]

The pull request draft ended up having many fix attempts, and I am not sure whether just pushing them one after another was the correct procedure. I envisioned that in a passing pull request all the commits would be squashed into a single commit having the the comment that I gave in the original commit, and the later comments would be ignored. This is the reason why the comments of the later commits do not have the correct format (and are not always particularly informative).
This has been fixed as suggested by nordicjm.

[nordicjm]

2 space indent

[Rautanyrkki]

Done

[nordicjm]

don't really see why just having the SPI NOR device in dts should enable SPI NOR, multithreading and flash, nor why there should be a Kconfig for this. If this is for MCUboot then submit a config file for MCUboot directly to the repo

[Rautanyrkki]

Removed

[nordicjm]

text is not aligned

[Rautanyrkki]

I am not sure what you mean. To me this looks similar to e.g. the arduino_header node in boards/nordic/nrf9160dk/nrf9160dk_nrf9160_common.dtsi. I did make some changes in the indentation of lines in the gpio-map field.

[nordicjm]

If you check in the review tab here https://github.com/zephyrproject-rtos/zephyr/pull/81437/files#diff-3b7bdd3eba91830df7d72e7821cef67abb42fccc74502b65af274ef3dc169f06R72 the green and blue options are indented more than the rest so they stick out, not required to fix anyhow

[Rautanyrkki]

Indentation fixed.

[nordicjm]

text is still not aligned but not a requirement to fix anyhow, just looks odd

[Rautanyrkki]

It seems that "Run tests with twister / twister-build (9)" has started to fail (due to build failure of sample.net.sockets.http.server) even though it has passed earlier. Based on this commit 8f07784 it seems that the test itself has been broken at some point. Is there a way to cause the tests rerun without pushing changes to the pull request? And are the run twister tests always taken from the current main branch?

[nordicjm]

Some nits. changes are OK

[nordicjm]

Suggested change

[Rautanyrkki]

Done

[nordicjm]

Suggested change

[Rautanyrkki]

Done

[nordicjm]

text is still not aligned but not a requirement to fix anyhow, just looks odd

[Rautanyrkki]

It seems that "Run tests with twister / twister-build (9)" has started to fail (due to build failure of sample.net.sockets.http.server) even though it has passed earlier. Based on this commit 8f07784 it seems that the test itself has been broken at some point. Is there a way to cause the tests rerun without pushing changes to the pull request? And are the run twister tests always taken from the current main branch?

Test remains failing after rebase and push.

[nordicjm]

Missed the int on this selection, non-default/new Kconfigs need to go into a Kconfig file

[nordicjm]

needs to move to Kconfig

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

[kartben]

@Rautanyrkki will you be able to come back to this pull request?

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.