Use defaults in iCE40 binding #81561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
cfriedt,
fkokosinski,
msierszulski and
tgorochowik
cfriedt
previously approved these changes
Nov 19, 2024
tgorochowik
previously approved these changes
Nov 20, 2024
henrikbrixandersen
requested changes
Nov 21, 2024
Member
There was a problem hiding this comment.
Default values in bindings need to be explained/justified in the description (please see https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#rules-for-default-values).
Replace the DT_INST_PROP_OR statements with defaults in the devicetree binding of the iCE40. Signed-off-by: Benedikt Schmidt <[email protected]>
benediktibk
dismissed stale reviews from tgorochowik, cfriedt, and josuah
via
46e6a1d
benediktibk
force-pushed
the
change/ice40_defaults
branch
from
de37c79 to
46e6a1d
Compare
josuah
approved these changes
Nov 21, 2024
cfriedt
approved these changes
Nov 21, 2024
tgorochowik
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the DT_INST_PROP_OR statements with defaults in the devicetree binding of the iCE40.