-
Notifications
You must be signed in to change notification settings - Fork 8.1k
add sdhc support on i.MX 91 FRDM board #97509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add sdhc support on i.MX 91 FRDM board #97509
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
44700b3
to
903d97b
Compare
Rebased and update west.yml to include the hal_nxp update which has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change request is about soc.h
if IMX_USDHC | ||
|
||
config GPIO | ||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also just do default y if IMX_USDHC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks.
sdmmc { | ||
compatible = "zephyr,mmc-disk"; | ||
disk-name = "SD2"; | ||
status = "disabled"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the node name sdmmc but the compatible is mmc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks
/* | ||
* Copyright 2025 NXP | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
#ifndef _SOC_NXP_IMX_IMX91_SOC_H_ | ||
#define _SOC_NXP_IMX_IMX91_SOC_H_ | ||
|
||
|
||
#endif /* _SOC_NXP_IMX_IMX91_SOC_H_ */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to include soc_common.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found currently soc_common.h includes some macro definitions and not useful so far, but anymore I added it at here.
903d97b
to
05c3f5b
Compare
|
To include the hal_nxp update for i.MX 93 SDHC. Signed-off-by: Jiafei Pan <[email protected]>
Add device nodes for SDHC. Signed-off-by: Lei Xu <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>
Some drivers need header file soc.h, according to Zephyr SoC Porting Guide soc.h must be provided for each SoC, so created an empty one. Signed-off-by: Lei Xu <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>
Added pinctrl and dts nodes for uSDHC1 and uSDHC2, they are disabled by default, and provided overlay files to enable them if needed. Signed-off-by: Lei Xu <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>
Increase CONFIG_MAIN_STACK_SIZE to 8192 to avoid possible crash. Signed-off-by: Lei Xu <[email protected]> Signed-off-by: Jiafei Pan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample change ok. Re-assigning to @decsny for the rest of stuff, this is NXP thing in the end.
add sdhc support on i.MX 91 FRDM board.
Depends on zephyrproject-rtos/hal_nxp#620 (has been merged)