Skip to content

Conversation

JiafeiPan
Copy link
Contributor

@JiafeiPan JiafeiPan commented Oct 14, 2025

add sdhc support on i.MX 91 FRDM board.

Depends on zephyrproject-rtos/hal_nxp#620 (has been merged)

Copy link

github-actions bot commented Oct 14, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@41d5acc zephyrproject-rtos/hal_nxp@a8ad9f2 zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@JiafeiPan
Copy link
Contributor Author

Rebased and update west.yml to include the hal_nxp update which has been merged.

@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 15, 2025
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change request is about soc.h

if IMX_USDHC

config GPIO
default y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also just do default y if IMX_USDHC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

Comment on lines 53 to 57
sdmmc {
compatible = "zephyr,mmc-disk";
disk-name = "SD2";
status = "disabled";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the node name sdmmc but the compatible is mmc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks

Comment on lines 1 to 16
/*
* Copyright 2025 NXP
*
* SPDX-License-Identifier: Apache-2.0
*/

#ifndef _SOC_NXP_IMX_IMX91_SOC_H_
#define _SOC_NXP_IMX_IMX91_SOC_H_


#endif /* _SOC_NXP_IMX_IMX91_SOC_H_ */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to include soc_common.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found currently soc_common.h includes some macro definitions and not useful so far, but anymore I added it at here.

@JiafeiPan JiafeiPan force-pushed the develop/imx91-frdm-sdhc branch from 903d97b to 05c3f5b Compare October 16, 2025 04:06
Copy link

JiafeiPan and others added 5 commits October 16, 2025 20:00
To include the hal_nxp update for i.MX 93 SDHC.

Signed-off-by: Jiafei Pan <[email protected]>
Add device nodes for SDHC.

Signed-off-by: Lei Xu <[email protected]>
Signed-off-by: Jiafei Pan <[email protected]>
Some drivers need header file soc.h, according to Zephyr SoC Porting Guide
soc.h must be provided for each SoC, so created an empty one.

Signed-off-by: Lei Xu <[email protected]>
Signed-off-by: Jiafei Pan <[email protected]>
Added pinctrl and dts nodes for uSDHC1 and uSDHC2, they are disabled
by default, and provided overlay files to enable them if needed.

Signed-off-by: Lei Xu <[email protected]>
Signed-off-by: Jiafei Pan <[email protected]>
Increase CONFIG_MAIN_STACK_SIZE to 8192 to avoid possible crash.

Signed-off-by: Lei Xu <[email protected]>
Signed-off-by: Jiafei Pan <[email protected]>
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample change ok. Re-assigning to @decsny for the rest of stuff, this is NXP thing in the end.

@de-nordic de-nordic assigned decsny and unassigned de-nordic Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants