Skip to content

drivers: display: features for ILI9341 driver #99267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

drivers: display: features for ILI9341 driver #99267

wants to merge 3 commits into from
+55 −62

Conversation

@NickIOT72
Copy link

@NickIOT72 NickIOT72 commented Nov 12, 2025

Overview

This PR adds some features on zephyr/driver/display files related with ili9xxx header

Features Implemented

  • modification on display_ili9xxx.c and display_ili9xxx.h files

  • add condition to select BGR/RGB color order depending on pixel format

  • change CMD_SET for ILI9341

Files Modified/Added

zephyr/drivers/display/display_ili9xxx.c - changes made on MADCTL register

zephyr/drivers/display/display_ili9xxx.h - Comment modified

zephyr/dts/bindings/display/ilitek,ili9xxx-common.yaml - Added BGR565 value on enum

zephyr/include/zephyr/dt-bindings/display/ili9xxx.h - added ILI9XXX_PIXEL_FORMAT_BGR565 on pixel format

Fixes #99134

@NickIOT72 NickIOT72 changed the title drivers: display: issue with configuration on ILI9341 drivers: display: features for ILI9341 driver Nov 12, 2025
JarmouniA
JarmouniA previously requested changes Nov 12, 2025
View reviewed changes
@JarmouniA JarmouniA self-assigned this Nov 12, 2025
danieldegrasse
danieldegrasse reviewed Nov 13, 2025
View reviewed changes
drivers/display/display_ili9xxx.h
enum madctl_cmd_set {
CMD_SET_1, /* Default for most of ILI9xxx display controllers */
CMD_SET_2, /* Used by ILI9342c */
CMD_SET_2, /* Used by ILI9342c & ILI9341 */
Copy link
Contributor

@danieldegrasse danieldegrasse Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that display orientation works with this change? Assuming that is why it was made

Copy link
Author

@NickIOT72 NickIOT72 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using CMD_SET_2 the display orientation works as described on the documentation . To verify it, I set a small delay between the squares rendering, comment the display_blanking_off and put it at the beginning. It was shown how each square was appearing according with the order set up on the script, showing the behaviour described on the document: clockwise, from TOP_LEFT(RED) to BOTTOM_LEFT(GRAY SCALE). I used RGB888 for the example

test_de

Copy link
Contributor

@JarmouniA JarmouniA Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add the delay between the squares in the sample, seems useful.

Copy link
Author

@NickIOT72 NickIOT72 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do that on this PR? or is better left it for another PR?

Copy link
Contributor

@JarmouniA JarmouniA Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do that on this PR? or is better left it for another PR?

Out-of-scope for this one

JarmouniA
JarmouniA reviewed Nov 14, 2025
View reviewed changes
@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from b56244b to 26a3faf Compare November 14, 2025 17:18
@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 area: Shields Shields (add-on boards) area: Tests Issues related to a particular existing or missing test platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond platform: Seeed Studio Seeed Studio platforms labels Nov 14, 2025
@NickIOT72 NickIOT72 requested a review from JarmouniA November 14, 2025 17:20
@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from 904bdca to ff6820f Compare November 14, 2025 21:23
@NickIOT72 NickIOT72 requested a review from JarmouniA November 14, 2025 21:24
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 14, 2025
JarmouniA
JarmouniA reviewed Nov 15, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete dt-bindings/display/ili9xxx.h

@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from ff6820f to 91844fb Compare November 15, 2025 11:59
@NickIOT72
Copy link
Author

NickIOT72 commented Nov 17, 2025

@JarmouniA 3 Commit set up on branch: 1 for original changes, another for dix-up changes and the last one for documentation

JarmouniA
JarmouniA reviewed Nov 17, 2025
View reviewed changes
@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from 91844fb to c2d40ed Compare November 17, 2025 18:51
JarmouniA
JarmouniA reviewed Nov 17, 2025
View reviewed changes
@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch 2 times, most recently from e72672f to 7131a9e Compare November 17, 2025 19:18
@NickIOT72 NickIOT72 requested a review from JarmouniA November 17, 2025 19:19
JarmouniA
JarmouniA reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit message title is incorrect.

@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from 7131a9e to 500faee Compare November 17, 2025 23:38
@NickIOT72
Copy link
Author

NickIOT72 commented Nov 17, 2025

Last commit message title is incorrect.

Commit message title changed

@NickIOT72 NickIOT72 requested a review from JarmouniA November 17, 2025 23:39
@NickIOT72
Copy link
Author

NickIOT72 commented Nov 20, 2025

@JarmouniA Commit message title changed

@JarmouniA JarmouniA dismissed their stale review November 20, 2025 14:24

addressed. CI failures to be fixed.

@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch 2 times, most recently from 57da9df to 4515947 Compare November 26, 2025 00:43
@zephyrbot zephyrbot requested a review from rerickson1 November 26, 2025 00:45
@NickIOT72
drivers: display: issue with configuration on ILI9341
dc4d497 
ILI9341 is not deploying correctly the display sample.
The screen looks mirrored vertically and the color
doesn't match with the sequence expected. To fix it,
change the Memory Access Control configuration data.

Signed-off-by: Nicolas Moreno <[email protected]>
@NickIOT72
drivers: display: features for ILI9341 driver
81b2323 
Replaced display-controller.yaml with lcd-controller.yaml
Deleted pixel format property, replacing it with the
property on lcd-controller.yaml. Replace ILI9XXX RGB macro
with PANEL RGB macro. Also, added condition to verify pixel
format is RGB565, BRG565 or RGB888, otherwise it will show error
Replaced <zephyr/dt-bindings/display/ili9xxx.h> with
<zephyr/dt-bindings/display/panel.h> and
ILI9XXX_PIXEL with PANEL_PIXEL in some Devicetrees
and files that contained both elements. Fixed some
script sintax. Deleted drivers/display/display_ili9xxx.c

Signed-off-by: Nicolas Moreno <[email protected]>
@NickIOT72
doc: releases: add ili9xxx fixes to 4.4 releases notes & migration guide
22e5b76 
Added documentation for doc/releases/migration-guide-4.4.rst
in reference with the changes on ili9xxx and ili9341
controllers

Signed-off-by: Nicolas Moreno <[email protected]>
@NickIOT72 NickIOT72 force-pushed the changes_display_ili9xxx_h branch from 4515947 to 22e5b76 Compare November 26, 2025 01:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@VynDragon VynDragon Awaiting requested review from VynDragon

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@avisconti avisconti Awaiting requested review from avisconti

@blauret blauret Awaiting requested review from blauret

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@ioannis-karachalios ioannis-karachalios Awaiting requested review from ioannis-karachalios

@kartben kartben Awaiting requested review from kartben

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@ydamigos ydamigos Awaiting requested review from ydamigos

@nashif nashif Awaiting requested review from nashif

@cfriedt cfriedt Awaiting requested review from cfriedt

@jhedberg jhedberg Awaiting requested review from jhedberg

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@rerickson1 rerickson1 Awaiting requested review from rerickson1

At least 2 approving reviews are required to merge this pull request.

Assignees

@JarmouniA JarmouniA

Labels

area: Boards/SoCs area: Devicetree Bindings area: Display area: Shields Shields (add-on boards) area: Tests Issues related to a particular existing or missing test platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond platform: Seeed Studio Seeed Studio platforms platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

driver: display: issues with ili9341 configuration

4 participants

@NickIOT72 @danieldegrasse @JarmouniA @zephyrbot