Copter/Sub: CIRCLE_RADIUS replaced by CIRCLE_RADIUS_M #31990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
force-pushed
the
copter47-param-conv-part3
branch
from
0d46d99 to
52713c3
Compare
amilcarlucas
previously requested changes
Jan 22, 2026
rmackay9
force-pushed
the
copter47-param-conv-part3
branch
from
52713c3 to
3e7e96e
Compare
Contributor
Author
|
I've tested this for Copter and Sub and have added a fix to Sub to allow it to detect changes to the CIRCLE_RADIUS_M parameter. This issue exists in master as well |
rmackay9
force-pushed
the
copter47-param-conv-part3
branch
from
f3ff835 to
c05fb3f
Compare
lthall
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #31970 and #31978 and addresses another part of issue #31562
This renames and rescales CIRCLE_RADIUS (in cm) to CIRCLE_RADIUS_M (in meters).
As a bit of a drive-by cleanup I've also moved some definitions from the AC_Circle.h file to the AC_Circle.cpp file to reduce their scope.
This has been tested in SITL to confirm the behaviour is as expected and also that the parameter conversion works correctly for both Copter and Sub.