Explain the limits on CI for first-time contributors#7679
Explain the limits on CI for first-time contributors#7679hunt0r wants to merge 1 commit intoArduPilot:masterfrom
Conversation
|
GitHub already handles all this automatically. Do you think we need additional guidance? It's pretty obvious IMO. |
Oh, no, I didn't realize that. Thank you. I'll close this. |
|
https://github.com/orgs/community/discussions/14334 . Obviously first timers do not get the button! |
|
Wait, do you know what is the experience from the first-timer's perspective? Sounds like these are the basics: That they need CI to be run, they can't do it themselves, and how to get assistance. Think that will be obvious already to them? |
|
Yes, I think it's the same but they do not get a button push. They get the prompt and the learn more and the warning though. |
|
The link points to https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks I don't think this is "obvious enough for first timers to know what to do". So I'm in favor of some heads-up in the wiki. |
|
I still think maintainers are pretty likely to notice and turn on. I certainly do it when I see it, and some users will already encounter it. And a maintainer already needs to touch the PR anyway! |
|
I'll move this to Draft. Probably you're right, no one will be confused, and I'll close it after a while. |
|
I don't think more explanation is worth it and certainly not with those wording that addcmore confusion and burden on maintainer. Github explaination for blocking CI is enough IMO |

In tonight's dev call, we made the decision to restrict this. This PR informs folks about it.
Rewording suggestions welcome!