Skip to content

Explain the limits on CI for first-time contributors#7679

Draft
hunt0r wants to merge 1 commit intoArduPilot:masterfrom
hunt0r:explain-first-timer-no-ci-rule
Draft

Explain the limits on CI for first-time contributors#7679
hunt0r wants to merge 1 commit intoArduPilot:masterfrom
hunt0r:explain-first-timer-no-ci-rule

Conversation

@hunt0r
Copy link
Copy Markdown
Contributor

@hunt0r hunt0r commented Apr 20, 2026

In tonight's dev call, we made the decision to restrict this. This PR informs folks about it.

Rewording suggestions welcome!

Comment thread dev/source/docs/submitting-patches-back-to-master.rst
@tpwrules
Copy link
Copy Markdown
Contributor

GitHub already handles all this automatically. Do you think we need additional guidance? It's pretty obvious IMO.

@hunt0r
Copy link
Copy Markdown
Contributor Author

hunt0r commented Apr 20, 2026

GitHub already handles all this automatically. Do you think we need additional guidance? It's pretty obvious IMO.

Oh, no, I didn't realize that. Thank you. I'll close this.

@hunt0r hunt0r closed this Apr 20, 2026
@tpwrules
Copy link
Copy Markdown
Contributor

tpwrules commented Apr 20, 2026

https://github.com/orgs/community/discussions/14334 . Obviously first timers do not get the button!

@hunt0r
Copy link
Copy Markdown
Contributor Author

hunt0r commented Apr 20, 2026

Wait, do you know what is the experience from the first-timer's perspective?

Sounds like these are the basics: That they need CI to be run, they can't do it themselves, and how to get assistance.
(It's also nice to explain why, IMO.)

Think that will be obvious already to them?

@tpwrules
Copy link
Copy Markdown
Contributor

Yes, I think it's the same but they do not get a button push. They get the prompt and the learn more and the warning though.

@hunt0r
Copy link
Copy Markdown
Contributor Author

hunt0r commented Apr 21, 2026

Here's what they get:
image

The link points to https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks

I don't think this is "obvious enough for first timers to know what to do". So I'm in favor of some heads-up in the wiki.
@tpwrules do you disagree?

@hunt0r hunt0r reopened this Apr 21, 2026
@tpwrules
Copy link
Copy Markdown
Contributor

I still think maintainers are pretty likely to notice and turn on. I certainly do it when I see it, and some users will already encounter it. And a maintainer already needs to touch the PR anyway!

@hunt0r
Copy link
Copy Markdown
Contributor Author

hunt0r commented Apr 21, 2026

I'll move this to Draft. Probably you're right, no one will be confused, and I'll close it after a while.

@hunt0r hunt0r marked this pull request as draft April 21, 2026 01:53
@khancyr
Copy link
Copy Markdown
Contributor

khancyr commented Apr 21, 2026

I don't think more explanation is worth it and certainly not with those wording that addcmore confusion and burden on maintainer. Github explaination for blocking CI is enough IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants