Merged
Conversation
apriltuesday
approved these changes
Sep 12, 2025
|
|
||
| Dependencies | ||
| Install biopython: | ||
| pip install biopython No newline at end of file |
There was a problem hiding this comment.
You can add this to the requirements file.
Since the requirements file is new in the main branch, you will either need to do it in your next PR, or you can dive into the joys of git rebase/merge to see how to update your branch with the newest changes from the main branch. In theory it's as simple as:
git checkout main
git pull origin main
git checkout populate_ref_allele
git rebase main
In practice there can be merge conflicts you need to resolve, but hopefully in this case there won't be.
Member
There was a problem hiding this comment.
We will address the issue with the requirements in #7 and that should also fix the tests
5235cc5 to
b2e4449
Compare
tcezard
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obtains a single base REF allele and populates the VCF file with it. Added option to provide the FASTA assembly file.