Skip to content

Conversation

jasagredo
Copy link
Contributor

No description provided.

@jasagredo jasagredo changed the base branch from main to js/db-analsyer-one-forker August 22, 2025 14:24
@jasagredo jasagredo force-pushed the js/db-analsyer-one-forker branch from 002b71e to f3e4dac Compare August 22, 2025 14:41
@jasagredo jasagredo requested a review from amesgen August 25, 2025 09:14
@jasagredo jasagredo force-pushed the js/forkers branch 2 times, most recently from 2421e01 to 062bcc8 Compare August 25, 2025 10:57
@jasagredo jasagredo force-pushed the js/db-analsyer-one-forker branch from f3e4dac to 2b121b4 Compare August 25, 2025 11:00
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not in scope for this PR, but the story around safely and correctly releasing resources for forkers is quite complicated (even more so with this PR), with some parts being handled by a ResourceRegistry and some parts by a special StrictTVar m (m ()). I wonder whether we could make some general improvements here; maybe the concept of a temporary registry a la runWithTempRegistry could be used to streamline this?

@jasagredo
Copy link
Contributor Author

jasagredo commented Aug 25, 2025

I plan on merging this as a PR stack:

This is a graph of the dependencies of the PRs

            ┌─────┐
            │#1653│
            └──┬──┘
               │
            ┌──▼──┐
            │#1652│
            └──┬──┘
               │
            ┌──▼──┐
            │#1603│
            └──┬──┘
               │
               │
            ┌──▼──┐
            │#1572│
            └─────┘
               │
   ┌───────┬───┴───┬───────┐
┌──▼──┐ ┌──▼──┐ ┌──▼──┐ ┌──▼──┐
│#1640│ │#1643│ │#1641│ │#1644│
└─────┘ └─────┘ └─────┘ └─────┘

@jasagredo jasagredo force-pushed the js/remove-shelley-byron branch from 2939d33 to 05bdb97 Compare August 27, 2025 16:04
@jasagredo jasagredo force-pushed the js/remove-shelley-byron branch 2 times, most recently from 450a323 to 773fa5c Compare August 29, 2025 09:57
Base automatically changed from js/remove-shelley-byron to main September 1, 2025 16:47
@jasagredo jasagredo enabled auto-merge September 2, 2025 09:35
@jasagredo jasagredo added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 2, 2025
@jasagredo jasagredo enabled auto-merge September 2, 2025 16:00
@jasagredo jasagredo added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit b24edf6 Sep 2, 2025
16 of 17 checks passed
@jasagredo jasagredo deleted the js/forkers branch September 2, 2025 23:38
@jasagredo jasagredo moved this to ✅ Done in Consensus Team Backlog Sep 3, 2025
@jasagredo jasagredo self-assigned this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants