Version ledger tables and encode TxIns in big-endian #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
nfrisby,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
jasagredo
force-pushed
the
js/version-tables
branch
2 times, most recently
from
198812f to
f7abd5b
Compare
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
94471a8 to
eb9dac9
Compare
This was referenced Sep 1, 2025
Merged
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
eb9dac9 to
b89e84a
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
f7abd5b to
9b557ad
Compare
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
b89e84a to
dfb21fe
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
9b557ad to
4d4c194
Compare
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
dfb21fe to
0de181c
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
4d4c194 to
a275075
Compare
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
0de181c to
51a81c5
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
a275075 to
f90853e
Compare
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
51a81c5 to
bec1fb6
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
f90853e to
545c7dc
Compare
fraser-iohk
reviewed
Sep 3, 2025
Comment on lines
+327
to
+331
| -- | The only purpose of this type is to modify the MemPack instance to use big | ||
| -- endian serialization. This is necessary to ensure streaming functions of the | ||
| -- UTxO set preserve the order of the entries, as otherwise we would get | ||
| -- different sortings if sorting via the Serialized form and the Haskell Ord | ||
| -- instance. |
There was a problem hiding this comment.
if we're explicitly only using this to ensure that the sorting is consistent between the serialized and unserialized versions, should there be a property test to ensure that this remains accurate?
There was a problem hiding this comment.
Very good point. I will add a test.
There was a problem hiding this comment.
FTR: As discussed today, this test will eventually be removed again, once we change the encoding for the benefit of the LSM compact index. Then, the test will actually start failing, which seems like a nice prompt to also remove this comment (instead explaining why it is fine that the Ord order and the serialization-implied order differ).
jasagredo
force-pushed
the
js/lsm-sc-da
branch
from
bec1fb6 to
a81a594
Compare
jasagredo
force-pushed
the
js/version-tables
branch
from
545c7dc to
8983b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.