Skip to content

Version ledger tables and encode TxIns in big-endian #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2025
Merged

Version ledger tables and encode TxIns in big-endian #1652

merged 5 commits into from
Oct 10, 2025

Conversation

@jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Aug 29, 2025 •
edited
Loading

Closes #1532

@jasagredo jasagredo force-pushed the js/version-tables branch 2 times, most recently from 198812f to f7abd5b Compare September 1, 2025 12:16
This was referenced Sep 1, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@jasagredo
Copy link
Contributor Author

jasagredo commented Sep 1, 2025 •
edited
Loading

out of date comment

@jasagredo jasagredo mentioned this pull request Sep 1, 2025
Merged
@jasagredo jasagredo mentioned this pull request Oct 10, 2025
Open
@jasagredo jasagredo force-pushed the js/version-tables branch 2 times, most recently from 8ffaa72 to 63a5dee Compare October 10, 2025 10:43
bladyjoker
bladyjoker approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm still amazed by the fact you caught this ordering shennanigans when it started causing issues 🥇

Base automatically changed from js/lsm-sc-da to main October 10, 2025 11:10
@jasagredo jasagredo enabled auto-merge October 10, 2025 11:13
@jasagredo jasagredo added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 90a926f Oct 10, 2025
16 of 18 checks passed
@jasagredo jasagredo deleted the js/version-tables branch October 10, 2025 13:32
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Consensus Team Backlog Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fraser-iohk fraser-iohk fraser-iohk left review comments

@bladyjoker bladyjoker bladyjoker approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby is a code owner

@amesgen amesgen Awaiting requested review from amesgen amesgen is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a is a code owner

Assignees

@jasagredo jasagredo

Labels

None yet

Projects

Consensus Team Backlog
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add versioning to Ledger tables on-disk storage

4 participants

@jasagredo @bladyjoker @amesgen @fraser-iohk